From owner-freebsd-testing@FreeBSD.ORG Thu Apr 10 22:19:36 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C5219378 for ; Thu, 10 Apr 2014 22:19:36 +0000 (UTC) Received: from mail-yh0-f50.google.com (mail-yh0-f50.google.com [209.85.213.50]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F4C51B05 for ; Thu, 10 Apr 2014 22:19:36 +0000 (UTC) Received: by mail-yh0-f50.google.com with SMTP id c41so4504696yho.23 for ; Thu, 10 Apr 2014 15:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=Rk4Az2ehqc/UbceVOYuemMPceoVnOIwESD2QaC/Ktv8=; b=IY/Py5MXUXGk8jvQPm1QndINa1XSCg0qVLE4ogUehC8VU6wIEje7YtGOjej0y0HF2q 3IkScGGiNmxMwXorKBLmgQ3cOpx5WppLTxGJ9PZSGxmzCMOvBkoVZdGuh2NYvQV9DyL3 eA8raZdA6PBHTN4laNZqQrHsp6jUlJthfX0CObr8aUfRQ8fTPj5hvCC7LuXTNnUpJ4nx rJkRvNdrX/NjytqKfxutNmrQxMbjxqNLWKDHJd+hEEySEpicgQm8PkkL8my0Q5a+GGUz xB1kJA87tgHdD3TU0G+RVUC1vOdry6EcB81c/sZdBehasa17c1kCYH2lElY8hgJAm+7G tbgA== X-Gm-Message-State: ALoCoQkTFBeHOlpEOXo3rF7pZOjTxuS/zifAibIUiVxeMRfp9CAIpHsl8ZeLG7fXgrRtW/MXSXoE X-Received: by 10.236.20.194 with SMTP id p42mr26611570yhp.56.1397168368987; Thu, 10 Apr 2014 15:19:28 -0700 (PDT) Received: from dhcp-172-26-107-241.nyc.corp.google.com (dhcp-172-26-107-241.nyc.corp.google.com [172.26.107.241]) by mx.google.com with ESMTPSA id z69sm10046153yha.26.2014.04.10.15.19.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 10 Apr 2014 15:19:28 -0700 (PDT) Sender: Julio Merino Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: Makefiles for skip-level directories? From: Julio Merino In-Reply-To: <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com> Date: Thu, 10 Apr 2014 18:19:02 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org> References: <16437CC5729B5345AF77F816513376E8129868F1@MX103CL02.corp.emc.com> <16437CC5729B5345AF77F816513376E820BAA20A@MX103CL02.corp.emc.com> <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com> <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1874) Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Apr 2014 22:19:36 -0000 On Apr 4, 2014, at 19:28, Garrett Cooper wrote: >=20 >> On Apr 4, 2014, at 15:28, "Peel, Casey" = wrote: >>=20 >> Ok, I figured it out and wrote up the following document (that is = published on our internal wiki). You may take whatever you want of this = for the FreeBSD wiki if you find it useful. >>=20 >> Something rcattelan pointed out while doing the code review for my = gpart changes that I wanted to run past you: >> is the include bsd.own.mk to pick up MK_TESTS? >> yes >> do you need to do that in the files that are not look at = MK_TESTS? >> geom/tests/Makefile ? >> I probably don't have to, but that's how the other Makefiles = like that are done in FreeBSD, eg: src/bin/tests/Makefile >> bsd.own.mk is included by bsd.init.mk which is included by = bsd.test.mk=20 >> so it seems redundant >> maybe we should ask the upstream if is correct ... might be = better to leave it off vs perpetuating something that might not be = right >=20 > Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit = on the cache, and increase the file sizes a small amount. >=20 > In the event that the Makefile snippet would be removed from the = included makefiles then stuff would break horribly. Plus it makes it = clear that MK_TESTS is obtained from bsd.own.mk. bsd.own.mk is not redundant if you are going to test for MK_TESTS; you = need that include. What I=92m not clear about is if bsd.own.mk ought to be bsd.init.mk or = not.=