From owner-cvs-all@FreeBSD.ORG  Mon Mar 22 18:06:47 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5878D16A4CE
	for <cvs-all@FreeBSD.org>; Mon, 22 Mar 2004 18:06:47 -0800 (PST)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 22B2043D46
	for <cvs-all@FreeBSD.org>; Mon, 22 Mar 2004 18:06:47 -0800 (PST)
	(envelope-from nate@root.org)
Received: (qmail 35962 invoked by uid 1000); 23 Mar 2004 02:06:48 -0000
Date: Mon, 22 Mar 2004 18:06:48 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: "David E. O'Brien" <obrien@FreeBSD.org>
In-Reply-To: <20040322223625.430EF16A4F2@hub.freebsd.org>
Message-ID: <20040322180452.A35931@root.org>
References: <20040322223625.430EF16A4F2@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_bus.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2004 02:06:47 -0000

On Mon, 22 Mar 2004, David E. O'Brien wrote:
>   Modified files:
>     sys/kern             subr_bus.c
>   Log:
>   Rather than display which interrupts are MPSAFE, display those that aren't.
>   This way we can take stock of the work to be done.  boot -v will note those
>   interrupts that are MPSAFE.
>
>   Revision  Changes    Path
>   1.141     +3 -1      src/sys/kern/subr_bus.c
>
>
> Index: src/sys/kern/subr_bus.c
> diff -u src/sys/kern/subr_bus.c:1.140 src/sys/kern/subr_bus.c:1.141
> --- src/sys/kern/subr_bus.c:1.140	Tue Feb 24 11:31:30 2004
> +++ src/sys/kern/subr_bus.c	Mon Mar 22 14:36:11 2004
> @@ -2148,7 +2148,9 @@
>  		error = BUS_SETUP_INTR(dev->parent, dev, r, flags,
>  		    handler, arg, cookiep);
>  		if (error == 0) {
> -			if (flags & INTR_MPSAFE)
> +			if (!(flags & INTR_MPSAFE))
> +				device_printf(dev, "[NOT!MPSAFE]\n");
> +			if (bootverbose && flags & INTR_MPSAFE)
>  				device_printf(dev, "[MPSAFE]\n");
>  			if (flags & INTR_FAST)
>  				device_printf(dev, "[FAST]\n");

I recommend you parenthesize (flags & INTR_MPSAFE).

-Nate