Date: Wed, 16 Jul 2014 19:59:57 +0000 From: Brooks Davis <brooks@freebsd.org> To: Sean Fagan <sef@ixsystems.com> Cc: hackers@freebsd.org Subject: Re: Expanding on NO_ROOT: Categorizing installed files Message-ID: <20140716195957.GI60425@spindle.one-eyed-alien.net> In-Reply-To: <3C71EBC2-4A4B-433D-8A21-D263CA0F24C0@ixsystems.com> References: <FE374F8B-ABF7-4497-B1C7-68E63612DC43@ixsystems.com> <20140716170758.GE60425@spindle.one-eyed-alien.net> <B0AABD58-E25C-4514-949E-4A91ED15B3BF@ixsystems.com> <20140716192410.GG60425@spindle.one-eyed-alien.net> <3C71EBC2-4A4B-433D-8A21-D263CA0F24C0@ixsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Jul 16, 2014 at 12:29:44PM -0700, Sean Fagan wrote:
> On Jul 16, 2014, at 12:24 PM, Brooks Davis <brooks@freebsd.org> wrote:
>
> > That said, I think the second argues that -P generating category= is the
> > wrong approach. Instead a new flag should just let you add arbitrary
> > stuff to the mtree file (subject to validation that it is well formed).
>
> -K <key>=<value> is easy enough to do, and seems mnemonical enough.
> (Then change the makefiles to have "-K category=${META_CATEGORY}"
> and whatnot.)
Sounds good.
> This doesn't get added to the mtree files, though. I played with changing
> mtree (well, nmtree), but I was thrown by the fact that it wasn't hierarchical --
> that is, adding a tag/label/whatever at one level didn't automatically percolate
> its way down. So I got rid of those changes.
The METALOG is an mtree file.
That sounds like a bug in the mtree code given the rational view that
unknown key=value's should just be passed along as text.
-- Brooks
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlPG2bwACgkQXY6L6fI4GtTWqQCeLNRea31tDcsWG7HOcXeKWkBO
XgIAmwSxUlyD7apAzh0ClIWvQQkNavX0
=3FPE
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716195957.GI60425>