Date: Mon, 6 Feb 2012 15:04:14 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Martin Matuska <mm@freebsd.org> Cc: freebsd-fs@freebsd.org Subject: Re: [CFR][DEVFS] Add "ruleset" mount option Message-ID: <20120206130414.GS3283@deviant.kiev.zoral.com.ua> In-Reply-To: <4F2FCEE6.1080400@FreeBSD.org> References: <4F2F9CB9.3040000@FreeBSD.org> <20120206123613.GR3283@deviant.kiev.zoral.com.ua> <4F2FCEE6.1080400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--8H2h1WtNxqGVRR8A Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 06, 2012 at 02:00:22PM +0100, Martin Matuska wrote: > On 6. 2. 2012 13:36, Konstantin Belousov wrote: > > On Mon, Feb 06, 2012 at 10:26:17AM +0100, Martin Matuska wrote: > >> The devfs(8) command supports configuring specific rulesets for devfs(= 5) > >> mounts. > >> However, it operates on already mounted devfs filesystems only and it = is > >> impossible to configure a specific ruleset on mount-time. > >> > >> The attached patch adds a "ruleset" mount option to devfs mounts. > >> The ruleset is automatically applied upon mount time. If the ruleset > >> doesn't exist, an empty ruleset with the given numer is created and > >> can be modified with devfs(8) later. > >> > >> The patch is also available at: > >> http://people.freebsd.org/~mm/patches/devfs/devfs_mount_ruleset.patch > >> > >> Please review and/or comment my attached patch. > >> > > Did you tested this with witness turned on ? It seems not. > Yes, I did, no warnings or error messages on my console. Are you sure ? Did you tried to change rulesets after mounting some devfs with ruleset option ? =46rom what I see, sx_rules is after dm_lock, e.g. in devfs_rules_ioctl(), while your patch insists on reversed order. --8H2h1WtNxqGVRR8A Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk8vz80ACgkQC3+MBN1Mb4i+KgCfcgdZL8oph+GjHsjy5qZt2mP6 JUUAoKaS7y2sQZxZIJl5vWI6HSCMohab =bloM -----END PGP SIGNATURE----- --8H2h1WtNxqGVRR8A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120206130414.GS3283>