From owner-p4-projects@FreeBSD.ORG  Fri Aug 29 14:44:19 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 3E2D816A4C1; Fri, 29 Aug 2003 14:44:19 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 031DB16A4BF
	for <perforce@freebsd.org>; Fri, 29 Aug 2003 14:44:19 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8BFED43FA3
	for <perforce@freebsd.org>; Fri, 29 Aug 2003 14:44:18 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h7TLiI0U060222
	for <perforce@freebsd.org>; Fri, 29 Aug 2003 14:44:18 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h7TLiISG060219
	for perforce@freebsd.org; Fri, 29 Aug 2003 14:44:18 -0700 (PDT)
Date: Fri, 29 Aug 2003 14:44:18 -0700 (PDT)
Message-Id: <200308292144.h7TLiISG060219@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 37195 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Aug 2003 21:44:19 -0000

http://perforce.freebsd.org/chv.cgi?CH=37195

Change 37195 by marcel@marcel_nfs on 2003/08/29 14:44:17

	Even though we have a 4-byte wide memory I/O resource,
	accessable registers of the z8530 have offsets:
		Channel B control	0
		Channel B data		2
		Channel A control	4
		Channel A data		6
	
	We're accessing bus space outside our assigned range.
	For now, give each port 4 bytes of bus space even though
	it's technically speaking invalid. Something is going on
	with sbus and I don't know yet what it is...

Affected files ...

.. //depot/projects/uart/dev/puc/puc_sbus.c#2 edit

Differences ...

==== //depot/projects/uart/dev/puc/puc_sbus.c#2 (text+ko) ====

@@ -68,7 +68,7 @@
 	for (i = 0; i < 2; i++) {
 		dd.ports[i].type = PUC_PORT_TYPE_UART | PUC_PORT_UART_Z8530;
 		dd.ports[i].bar = 0;
-		dd.ports[i].offset = 0x2 * i;
+		dd.ports[i].offset = 4 * i;
 		dd.ports[i].serialfreq = 0;
 		dd.ports[i].flags = PUC_FLAGS_MEMORY;
 	}