Date: Tue, 31 Jul 2012 12:02:37 -0500 From: Bryan Drewery <bryan@shatow.net> To: Niclas Zeising <zeising@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301719 - head/databases/aolserver-nspostgres Message-ID: <50180FAD.6030607@shatow.net> In-Reply-To: <5016AE95.4090805@freebsd.org> References: <201207301530.q6UFUaOr007302@svn.freebsd.org> <5016AACF.5090700@shatow.net> <5016AE95.4090805@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/30/2012 10:56 AM, Niclas Zeising wrote: > On 07/30/12 17:39, Bryan Drewery wrote: >> This is not the patch I sent in. >> >> As I said in the PR, I purposely moved DISTVERSIONSUFFIX to fix a >> portlint error, which still exists now. >> >> # portlint . >> FATAL: Makefile: DISTVERSIONSUFFIX appears out-of-order. >> FATAL: Makefile: order must be >> PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY. >> >> 2 fatal errors and 0 warnings found. > > Me and my mentor decided that it made more sense to keep > DISTVERSIONSUFFIX where it is, since it is connected to the name of the > port. Looking closely at the output of portlint, DISTVERSIONSUFFIX > should really be *before* PORTREVISION, not halfway down the makefile. > That portlint grows quiet when it is put there is arguably a bug in > portlint. I'll look into this more and see if portlint needs to be updated. I was just surprised, would have been nice to be part of the discussion :) > >> >> Adding USE_LDCONFIG may change behavior as well. I had left it out as I >> had not tested it yet. > > It is my understanding that all ports that install shared libraries > should have USE_LDCONFIG=yes in their makefile. Portlint tells you as > much if I am not mistaken. Definitely should use it, I'm just unsure of the impact on how aolserver loads the modules. Not likely to hurt. Will look into it more. Thanks, Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50180FAD.6030607>