From owner-freebsd-arch Thu Apr 19 5:48: 7 2001 Delivered-To: freebsd-arch@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id AB74037B423 for ; Thu, 19 Apr 2001 05:47:55 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 1438 invoked by uid 1000); 19 Apr 2001 12:46:12 -0000 Date: Thu, 19 Apr 2001 15:46:11 +0300 From: Peter Pentchev To: Bruce Evans Cc: Matt Dillon , Alfred Perlstein , Terry Lambert , arch@FreeBSD.ORG Subject: Re: Found BAD BUG: squashed Message-ID: <20010419154611.D1067@ringworld.oblivion.bg> Mail-Followup-To: Bruce Evans , Matt Dillon , Alfred Perlstein , Terry Lambert , arch@FreeBSD.ORG References: <20010419105902.B3605@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from bde@zeta.org.au on Thu, Apr 19, 2001 at 10:44:12PM +1000 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Thu, Apr 19, 2001 at 10:44:12PM +1000, Bruce Evans wrote: > On Thu, 19 Apr 2001, Peter Pentchev wrote: > > > Would there be any bad implications of upping cr_ref to 32-bit before 4.3? > > Besides binary compatibility? (I know, I know.. recompiling third-party > > kernel modules and all..) > > It's hard to tell with only 1 day to test :-). Non-bloatage of the struct > makes bugs less obvious. If not all the modules are compiled, then some > modules may provide (nonzero) garbage in the padding after cr_ref. This > will be interpreted as a large refcount by new kernels and ucreds will > never be freed. Ack. I never thought of stale modules. Point taken - there might also be LOTS of other things I - or others - have not thought of :) G'luck, Peter -- I am not the subject of this sentence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message