From owner-cvs-src@FreeBSD.ORG  Fri May 21 00:26:17 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 54DC416A4CE; Fri, 21 May 2004 00:26:17 -0700 (PDT)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D569A43D1F; Fri, 21 May 2004 00:26:16 -0700 (PDT)
	(envelope-from scottl@freebsd.org)
Received: from freebsd.org (junior-wifi.samsco.home [192.168.0.11])
	by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i4L7VoYG041506;
	Fri, 21 May 2004 01:31:50 -0600 (MDT)
	(envelope-from scottl@freebsd.org)
Message-ID: <40ADAF07.2070909@freebsd.org>
Date: Fri, 21 May 2004 01:25:59 -0600
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040304
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Warner Losh <imp@freebsd.org>
References: <200405210636.i4L6aadV059034@repoman.freebsd.org>
In-Reply-To: <200405210636.i4L6aadV059034@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/pci pci.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2004 07:26:17 -0000

Warner Losh wrote:
> imp         2004/05/20 23:36:36 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/pci          pci.c 
>   Log:
>   MFp4: o save/restore subvendor, subdevice, vendor, device, baseclass,
>           subclass, progif and revid.  While these are typically read
>           only fields, they aren't always read-only.  progif is writable
>           for ata devices, for example.  It does no harm when they are
>           read only, and helps when they aren't.
>   
>   Revision  Changes    Path
>   1.252     +16 -0     src/sys/dev/pci/pci.c

Shouldn't it be left up to the device drivers to decide if a buggy piece
of silicon needs to be touched like this?  I really don't like the bus
unilaterally enforcing this on everything.

Scott