From owner-svn-ports-head@FreeBSD.ORG Tue Jul 31 17:02:33 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5CF061065687 for ; Tue, 31 Jul 2012 17:02:33 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 000498FC23 for ; Tue, 31 Jul 2012 17:02:32 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sweb; b=OaI1ra NCewn7TcudyTjMEDbvn4aclAqEti9PKjJk7JKmPRe2wPsS3wvlXZlfNRB6+LbNys FO+8jwO6oXwuSlyS8PnAVz219yzxXa2p0Kpo0Uuc8HiTgLk4yQGQrzISn2mlzYog fMh3NLqQ0LZOgy39EKlC5huoFBmNns9noVaUY= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sweb; bh=Bx44C4iJeerf zPCgFtjBheKGQYQGD3jNzW5Bi7LmUw0=; b=eo0P34kKJ7Jc+ivkZmFT4/noXWim y+onu5QCCpkbvxKHH3ViSb51BEq8owIDfzDt83kcyCJ5HkeVA9JuI4MLe0DGz3sW tcjEZPotOXGv+NsIGxokQJfsrPPVUcYbHW5bNjV73s3+efH81QyKbJZtOFBdorYc jpJCD2GmltHamj4= Received: (qmail 58661 invoked from network); 31 Jul 2012 12:02:30 -0500 Received: from unknown (HELO ?192.168.0.74?) (bryan@shatow.net@74.94.87.209) by sweb.xzibition.com with ESMTPA; 31 Jul 2012 12:02:30 -0500 Message-ID: <50180FAD.6030607@shatow.net> Date: Tue, 31 Jul 2012 12:02:37 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Niclas Zeising References: <201207301530.q6UFUaOr007302@svn.freebsd.org> <5016AACF.5090700@shatow.net> <5016AE95.4090805@freebsd.org> In-Reply-To: <5016AE95.4090805@freebsd.org> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301719 - head/databases/aolserver-nspostgres X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2012 17:02:33 -0000 On 7/30/2012 10:56 AM, Niclas Zeising wrote: > On 07/30/12 17:39, Bryan Drewery wrote: >> This is not the patch I sent in. >> >> As I said in the PR, I purposely moved DISTVERSIONSUFFIX to fix a >> portlint error, which still exists now. >> >> # portlint . >> FATAL: Makefile: DISTVERSIONSUFFIX appears out-of-order. >> FATAL: Makefile: order must be >> PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY. >> >> 2 fatal errors and 0 warnings found. > > Me and my mentor decided that it made more sense to keep > DISTVERSIONSUFFIX where it is, since it is connected to the name of the > port. Looking closely at the output of portlint, DISTVERSIONSUFFIX > should really be *before* PORTREVISION, not halfway down the makefile. > That portlint grows quiet when it is put there is arguably a bug in > portlint. I'll look into this more and see if portlint needs to be updated. I was just surprised, would have been nice to be part of the discussion :) > >> >> Adding USE_LDCONFIG may change behavior as well. I had left it out as I >> had not tested it yet. > > It is my understanding that all ports that install shared libraries > should have USE_LDCONFIG=yes in their makefile. Portlint tells you as > much if I am not mistaken. Definitely should use it, I'm just unsure of the impact on how aolserver loads the modules. Not likely to hurt. Will look into it more. Thanks, Bryan Drewery