From owner-freebsd-current@freebsd.org Thu Aug 13 16:35:07 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 255019B877B; Thu, 13 Aug 2015 16:35:07 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DA3DAA92; Thu, 13 Aug 2015 16:35:06 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t7DGZ00U086838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Aug 2015 09:35:00 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t7DGZ0oM086835; Thu, 13 Aug 2015 09:35:00 -0700 (PDT) (envelope-from jmg) Date: Thu, 13 Aug 2015 09:35:00 -0700 From: John-Mark Gurney To: Conrad Meyer Cc: Stefano Garzarella , freebsd-current , "freebsd-virtualization@freebsd.org" , Neel Natu , Peter Grehan Subject: Re: bhyve: fix bhyve warning CTASSERT Message-ID: <20150813163459.GW68509@funkthat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Thu, 13 Aug 2015 09:35:00 -0700 (PDT) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 16:35:07 -0000 Conrad Meyer wrote this message on Thu, Aug 13, 2015 at 08:12 -0700: > Better to just replace CTASSERT() with _Static_assert() while you're here. And make sure that sys/cdefs.h is included for compatibility w/ pre-C11 compilers... > On Thu, Aug 13, 2015 at 5:05 AM, Stefano Garzarella > wrote: > > Hi all, > > when I compile bhyve, I have the following errors from clang: > > pci_emul.c:750:2: error: unused typedef '__assert750' > > [-Werror,-Wunused-local-typedef] > > CTASSERT(sizeof(struct msicap) == 14); > > pci_emul.c:776:2: error: unused typedef '__assert776' > > [-Werror,-Wunused-local-typedef] > > CTASSERT(sizeof(struct msixcap) == 12); > > pci_emul.c:928:2: error: unused typedef '__assert928' > > [-Werror,-Wunused-local-typedef] > > CTASSERT(sizeof(struct pciecap) == 60); > > > > I fixed them in this simple way: > > > > diff --git a/bhyverun.h b/bhyverun.h > > index 87824ef..7ac3aa9 100644 > > --- a/bhyverun.h > > +++ b/bhyverun.h > > @@ -32,7 +32,8 @@ > > #ifndef CTASSERT /* Allow lint to override */ > > #define CTASSERT(x) _CTASSERT(x, __LINE__) > > #define _CTASSERT(x, y) __CTASSERT(x, y) > > -#define __CTASSERT(x, y) typedef char __assert ## y[(x) ? 1 > > : -1] > > +#define __CTASSERT(x, y) typedef char __assert ## y[(x) ? 1 > > : -1] \ > > + __unused > > #endif -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."