From owner-freebsd-current@FreeBSD.ORG Thu Apr 30 20:48:33 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE41C106566B for ; Thu, 30 Apr 2009 20:48:33 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from contrabass.post.ru (contrabass.post.ru [85.21.78.5]) by mx1.freebsd.org (Postfix) with ESMTP id 9A2108FC17 for ; Thu, 30 Apr 2009 20:48:33 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.post.ru (Postfix) with ESMTP id 40B99953D0; Fri, 1 May 2009 00:48:31 +0400 (MSD) X-Virus-Scanned: by cgpav Uf39PSi9pFi9oFi9 Received: from [10.208.17.3] (HELO dchagin.static.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPS id 1769035887; Fri, 01 May 2009 00:48:31 +0400 Received: from dchagin.static.corbina.ru (localhost.chd.net [127.0.0.1]) by dchagin.static.corbina.ru (8.14.3/8.14.3) with ESMTP id n3UKmUlR006604; Fri, 1 May 2009 00:48:30 +0400 (MSD) (envelope-from dchagin@dchagin.static.corbina.ru) Received: (from dchagin@localhost) by dchagin.static.corbina.ru (8.14.3/8.14.3/Submit) id n3UKmSZT006603; Fri, 1 May 2009 00:48:28 +0400 (MSD) (envelope-from dchagin) Date: Fri, 1 May 2009 00:48:28 +0400 From: Chagin Dmitry To: Robert Watson Message-ID: <20090430204828.GA6551@dchagin.static.corbina.ru> References: <20090430155408.GX1387@albert.catwhisker.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Cc: current@freebsd.org Subject: Re: Panic: witness_warn (r191682; shared rw udpinp (udpinp)...netinet6/udp6_usrreq.c:360) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2009 20:48:34 -0000 --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 30, 2009 at 08:27:48PM +0100, Robert Watson wrote: >=20 > On Thu, 30 Apr 2009, David Wolfskill wrote: >=20 > > Build machine crashed on boot of r191682: > > > > ... > > GEOM_LABEL: Label ufsid/48fa940b4445475f removed. > > fxp0: link state changed to UP > > suspending ithread with the following locks held: > > shared rw udpinp (udpinp) r =3D 0 (0xc5ac4f3c) locked @ /usr/src/sys/ne= tinet6/udp6_usrreq.c:360 > > panic: witness_warn > > cpuid =3D 1 > > KDB: enter: panic > > [thread pid 12 tid 100008 ] > > Stopped at kdb_enter+0x3a: movl $0,kdb_why > > db> > > > > I started to paste the output of "show witness" in here, but it got to = be=20 > > sufficiently lengthy that I thought it better to save it for private ma= il or=20 > > a follow-up if it's really wanted. >=20 > This falls into the category of "unlikely software bugs" -- is there any= =20 > chance this machine is overheating or has memory problems? "show alllock= s"=20 > would be helpful on general principle, though. >=20 hi Robert, look at patch bellow (even not tested, only to show a problem): diff --git a/sys/netinet6/udp6_usrreq.c b/sys/netinet6/udp6_usrreq.c index 5393740..f8ac3f2 100644 --- a/sys/netinet6/udp6_usrreq.c +++ b/sys/netinet6/udp6_usrreq.c @@ -357,7 +357,6 @@ udp6_input(struct mbuf **mp, int *offp, int proto) UDPSTAT_INC(udps_noportmcast); goto badheadlocked; } - INP_RLOCK(last); INP_INFO_RUNLOCK(&V_udbinfo); if (last->inp_ppcb !=3D NULL) { /* David, can you test this patch? thnx! --=20 Have fun! chd --DocE+STaALJfprDB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEARECAAYFAkn6DpsACgkQ0t2Tb3OO/O1sdwCgs5nHmV0ciGgyRE3vD2Qx6+/X mPgAnA0zuy+0IomsfuGeny2TWxV/ZXJb =Abzn -----END PGP SIGNATURE----- --DocE+STaALJfprDB--