From owner-svn-src-head@FreeBSD.ORG Thu May 30 15:37:55 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BA9A04C9; Thu, 30 May 2013 15:37:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 14BB7F5D; Thu, 30 May 2013 15:37:54 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r4UFbpSj090176; Thu, 30 May 2013 18:37:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r4UFbpSj090176 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r4UFbpTl090175; Thu, 30 May 2013 18:37:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 30 May 2013 18:37:51 +0300 From: Konstantin Belousov To: Brooks Davis Subject: Re: svn commit: r251140 - head Message-ID: <20130530153750.GB3047@kib.kiev.ua> References: <201305301409.r4UE9wSP009396@svn.freebsd.org> <201305301053.23282.jhb@freebsd.org> <20130530152933.GB36644@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PYiEBKzE38FzKR5p" Content-Disposition: inline In-Reply-To: <20130530152933.GB36644@lor.one-eyed-alien.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 15:37:55 -0000 --PYiEBKzE38FzKR5p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 30, 2013 at 10:29:33AM -0500, Brooks Davis wrote: > On Thu, May 30, 2013 at 10:53:23AM -0400, John Baldwin wrote: > > On Thursday, May 30, 2013 10:09:58 am Brooks Davis wrote: > > > Author: brooks > > > Date: Thu May 30 14:09:58 2013 > > > New Revision: 251140 > > > URL: http://svnweb.freebsd.org/changeset/base/251140 > > >=20 > > > Log: > > > Always define INSTALL_DDIR and define it such that it contains no e= xtra > > > / characters rather than removing them later on. This should fix > > > release builds. > > > =20 > > > PR: conf/178963 > > > Reviewed by: gjb, hrs > > >=20 > > > Modified: > > > head/Makefile.inc1 > > >=20 > > > Modified: head/Makefile.inc1 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/Makefile.inc1 Thu May 30 14:07:14 2013 (r251139) > > > +++ head/Makefile.inc1 Thu May 30 14:09:58 2013 (r251140) > > > @@ -522,7 +523,7 @@ _includes: > > > @echo "------------------------------------------------------------= --" > > > @echo ">>> stage 4.1: building includes" > > > @echo "------------------------------------------------------------= --" > > > - ${_+_}cd ${.CURDIR}; ${WMAKE} SHARED=3Dsymlinks par-includes > > > + ${_+_}cd ${.CURDIR}; ${WMAKE} par-includes > > > _libraries: > > > @echo > > > @echo "------------------------------------------------------------= --" > >=20 > > Did you mean to change this? It seems unrelated. >=20 > Oops, I forgot that I had that in for testing. Reverted in 251141. >=20 > That said, the SHARED=3D(copies|symlinks) code should probably go on the > chopping block. It's a lousy idea except for populating WORLDTMP and > here it saves at most 1.5% in /usr/obj. Worse, the implementation is > hand coded in each Makefile so it adds complexity for a mostly useless > feature. I disagree with the statement about the useless, at least for WORLDTMP it saves the full buildworld when a change in the usermode headers is done during the development. E.g., changing include/* or sys/sys/* still allows to build libc with buildenv, instead of spending 40+ minutes on the buildworld. --PYiEBKzE38FzKR5p Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJRp3JOAAoJEJDCuSvBvK1BJQ8P/3sAS5LuOYQG6emQ8xMUdAz8 +f+0229U/r8XmujWOcDuU/C3sq1xrj4mSLFvTGtsicwmAWyiRgAcm33EW/o/fdH/ pxZFeYre/nRJhIbJ75JqrON3l07i8C6N6+dHqruv3hPLCRJ5pBW3dEDAnF1rjWJU vCVgaVhm0L8eViEPL2MZvV7m614HnKbd6uWpFP8mdHw2W/4tvjDg8fHo45ndJXv9 f4vcmne716x4+2BAKlMwJWplotGDnVUP7GUD9g+aclKriCxkiVtLZeSTEFLfeXHk SZW4tP68KIUrzvuSVzs7GGNjpLI0sgdq616PP5R4VbKGJLbHUB+5Sri5etJn+fIz K5RPkFLvznDfG9XjViM2cFt4PFTId/in8nxArQD6lelQpT7qMzN6PGwkcMqT3HHv AELmq9SiUzdznQ2/5/JtwtpWL55/WU0wdx3IXlYJiC9tBMhsIjAZxv/YJddGWqBb 4uPvTl2a/jUHV+a/yLmJrKiUm514+RL5MLfyKZukSTWIF5ssAS7H7VdrCvPPeVXP +pqxIqE5sJFASVv2A/ZxbvFS5+cT/DW9rIbAKZ5uoihtTfsc80lO+cDvlUI6kqQf ZN1qS7LKF0aizmxQCPeUT9nyJiw6/izP1qBZHhj+qAsOqg+p9L4iBI+yxRZY1bYP szRgHgytHXkHnJIxX426 =yGXJ -----END PGP SIGNATURE----- --PYiEBKzE38FzKR5p--