From owner-svn-src-head@FreeBSD.ORG Mon Nov 3 19:00:35 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 80140A77; Mon, 3 Nov 2014 19:00:35 +0000 (UTC) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) by mx1.freebsd.org (Postfix) with ESMTP id 5B752AE1; Mon, 3 Nov 2014 19:00:35 +0000 (UTC) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 9B6F45A9F25; Mon, 3 Nov 2014 19:00:29 +0000 (UTC) Date: Mon, 3 Nov 2014 19:00:29 +0000 From: Brooks Davis To: John-Mark Gurney Subject: Re: svn commit: r273955 - in head: etc/rc.d share/man/man7 Message-ID: <20141103190029.GB29192@spindle.one-eyed-alien.net> References: <201411020011.sA20BQsh038825@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline In-Reply-To: <201411020011.sA20BQsh038825@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 19:00:35 -0000 --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 02, 2014 at 12:11:26AM +0000, John-Mark Gurney wrote: > Author: jmg > Date: Sun Nov 2 00:11:25 2014 > New Revision: 273955 > URL: https://svnweb.freebsd.org/changeset/base/273955 >=20 > Log: > add an rc.d script to automatically grow the specified FS... It has > been tested on both MBR and GPT... It won't be enabled until you add > growfs_enable=3D"YES" and will only run on first boot.. Nice. I've been wanting something like this for our boards. A few comments: - It looks like the current script doesn't support specifying a file system and just finds the root dev. As a practical matter being able to specify one probably isn't useful without doing the work to extend the last partition on a device, but I could see cases where /usr or the like is on removable media an / is an mdroot or otherwise on fixed size storage. - Being able to specify a size would be useful. For example, I might want to growfs to 2GB by default and expand to the media size later if warranted. - A configurable delay during which ^C causes growfs to be skipped would be useful when testing an image. Growfs on large or very slow media is something I'd like to be able to avoid when I'm just testing. - The shell lines should probably use tab for indentation to match system style and the awk bits. -- Brooks --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlRX0MwACgkQXY6L6fI4GtRklwCfRT1aTetq0Kr87b8tfMb3pwTt 2JsAoJbBpyzXvRsBHJlIsqHfyqJrYmh+ =bVWY -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5--