From nobody Tue Dec 26 02:04:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SzdPL0tGCz55KHH; Tue, 26 Dec 2023 02:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SzdPK6Hgcz4KF3; Tue, 26 Dec 2023 02:04:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703556261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XmpvYjPwwQhnbR5u6d/wDoCPkoepk0Qjilru+yXx73g=; b=YIantpl9HpJVmZbnLvkFY6JDo+XevCL1oJnT8Zl6r6kRuyjlvsn+MIDJZqC0gbfHVhxrde 7sQ1Sn+R6qGd3QzFo/5x/QtvCLxnGqTzolxAEya8ZmPLxwa0I4FaNtd5xpM/7xc8+zZPWp g9LzopEMZAUqRFJjk2pfhPY9UsSEOWvhBAzmslkRLFWrdyn2NvxigxQ7jfjF3vVfiaBnEa EH2N79lmks4DbmCMwh9QZ6cTEyf0XxFj9vgP+F8g94gFrxud7FqKeyNJEMFZh0RskwX8Q7 sor9vMdqsYsziTHYbzzfnF6k/ASbcLW2eLdur7k0rW+c5rpxM7cEYg7tYp75XQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703556261; a=rsa-sha256; cv=none; b=YGAVcTWPQsHgJXt43kxp3riPcEYI/foeIbqXwEgnQbgSDW3aYPMaV4rV7dA2Nl0yn50MCo 5WnZuGVayk1fNnAT2RSi1jznJTbC7Olqu0fvPa4w2UeZ+dthi8VjavIgIu/jCmHTxTi5Lu s7ModkOH7ojOSYQMKa/0YUxZGUc/YShhomIzYxOQJY7i2mdcbI1zm0KSdYBXj0siiYdqaZ 3gsp9LDKnU56w6k0yDMq9M/doJJ8PtCIV4K/u18WpoKCtC9mutNF4pV2oMPPOFSRhd5odn V5WK+LH2ih9jspiOo7Xnp7Eqwony4ZNO4Lg8ZNpQyrNMVJ2vlfzpylfELqPLnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703556261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XmpvYjPwwQhnbR5u6d/wDoCPkoepk0Qjilru+yXx73g=; b=lOloTHKdAJfHR0B2vPbygcAbm8BnQrRpCQF49FxTx5l+CQybG6LxjhH2PsB7VuoFHEEYvs reCs4iufnmoAud7VQQvICsP/3LZVhCENHvEJ2Ug0d7pGaPAv1YRY4zv1+yxQC6sxaXiRNL t9Yjzedo3g5BT8mPRgdrkVCXaL5Wrnx4/7OEb8b4WqgiLakMu5O9xdtQGlkyrDMK8xEmX/ fe9b3uzv/hijaB3ciYgBAqZYIngT22ugmw4y3yIy/tw51PzM/CZPxXaaR08dAudoNg5QeV 2zuaa4LF4uNM6THYG9ktqVEThgZhXXWa4NkSMfVmvsyYbTTblAWgJTWQedp/jg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SzdPK5Nyyzc5X; Tue, 26 Dec 2023 02:04:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3BQ24LZh003098; Tue, 26 Dec 2023 02:04:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3BQ24Lr9003095; Tue, 26 Dec 2023 02:04:21 GMT (envelope-from git) Date: Tue, 26 Dec 2023 02:04:21 GMT Message-Id: <202312260204.3BQ24Lr9003095@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: bdf03b4bcc4a - main - powerpc: Avoid ignoring copyin()'s return value List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bdf03b4bcc4a9aa0be503dbc64415e6b0b845fbc Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=bdf03b4bcc4a9aa0be503dbc64415e6b0b845fbc commit bdf03b4bcc4a9aa0be503dbc64415e6b0b845fbc Author: Mark Johnston AuthorDate: 2023-12-26 01:40:16 +0000 Commit: Mark Johnston CommitDate: 2023-12-26 02:04:00 +0000 powerpc: Avoid ignoring copyin()'s return value A recent change made it possible for cpu_set_upcall() to return an error. Do that here instead of ignoring an error from copyin(). Reviewed by: jhibbits MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D43105 --- sys/powerpc/powerpc/exec_machdep.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/powerpc/powerpc/exec_machdep.c b/sys/powerpc/powerpc/exec_machdep.c index 0c10115c4e25..94e561ddd33a 100644 --- a/sys/powerpc/powerpc/exec_machdep.c +++ b/sys/powerpc/powerpc/exec_machdep.c @@ -1155,6 +1155,9 @@ cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, { struct trapframe *tf; uintptr_t sp; + #ifdef __powerpc64__ + int error; + #endif tf = td->td_frame; /* align stack and alloc space for frame ptr and saved LR */ @@ -1182,10 +1185,12 @@ cpu_set_upcall(struct thread *td, void (*entry)(void *), void *arg, tf->srr0 = (register_t)entry; /* ELFv2 ABI requires that the global entry point be in r12. */ tf->fixreg[12] = (register_t)entry; - } - else { + } else { register_t entry_desc[3]; - (void)copyin((void *)entry, entry_desc, sizeof(entry_desc)); + error = copyin((void *)entry, entry_desc, + sizeof(entry_desc)); + if (error != 0) + return (error); tf->srr0 = entry_desc[0]; tf->fixreg[2] = entry_desc[1]; tf->fixreg[11] = entry_desc[2];