From owner-freebsd-commit  Tue Apr  4 07:30:03 1995
Return-Path: commit-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id HAA13377 for commit-outgoing; Tue, 4 Apr 1995 07:30:03 -0700
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id HAA13282 for cvs-sys-outgoing; Tue, 4 Apr 1995 07:28:17 -0700
Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id HAA13184; Tue, 4 Apr 1995 07:26:40 -0700
Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id IAA05860; Tue, 4 Apr 1995 08:30:28 -0600
Date: Tue, 4 Apr 1995 08:30:28 -0600
Message-Id: <199504041430.IAA05860@trout.sri.MT.net>
To: Mike Pritchard <pritc003@maroon.tc.umn.edu>
Cc: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes), nate@freefall.cdrom.com,
        CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com
Subject: Re: cvs commit: src/sys/i386/conf Makefile.i386
In-Reply-To: <199504040719.CAA07819@mpp.com>
References: <199504030240.TAA03137@gndrsh.aac.dev.com>
	<199504040719.CAA07819@mpp.com>
Reply-To: nate@sneezy.sri.com (Nate Williams)
From: nate@sneezy.sri.com (Nate Williams)
Sender: commit-owner@FreeBSD.org
Precedence: bulk

> > >   Modified:    sys/i386/conf Makefile.i386
> > >   Log:
> > >   Added -I/usrinclude to the tail end of the INCLUDES line.  This hack
> > >   will cause kernel compiles to work even if the src/includes directory
> > >   doesn't exist but still do the 'Right Thing' and pull files from the
> > >   source tree if it does exist.
> 
> My feelings are that you should be able to build anything in /usr/src
> without /usr/include even being present on the machine you are running
> the build on.

I've re-read what I wrote a couple times, and it must not be obvious
even though I think it makes sense to me.  I'm getting people arguing
with the change from both ends.

The previous behavior (before my change) caused the kernel to bring in
include files from the /usr/src tree.  This is what you want.

However, if you *don't* have /usr/src/include installed an you've only
installed the bindist then the change I made allows the kernel to
compile.  This is normal behavior for most folks who want to build a
custom kernel.  They don't want to install the entire src dist. just to
build a kernel.

But, *IF* both the src dist and /usr/include directories exist, the
include files are pulled out of /usr/src/include if they exist and
/usr/include next.  (Which should never happen since /usr/src/include
should always contain all of the necessary include files which aren't in
the /usr/src/sys tree)


Nate