From owner-p4-projects@FreeBSD.ORG  Mon Jan 29 13:55:03 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 72D8C16A404; Mon, 29 Jan 2007 13:55:03 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 321CB16A402
	for <perforce@FreeBSD.org>; Mon, 29 Jan 2007 13:55:03 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 1566913C4A3
	for <perforce@FreeBSD.org>; Mon, 29 Jan 2007 13:55:03 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0TDsxsk025391
	for <perforce@FreeBSD.org>; Mon, 29 Jan 2007 13:54:59 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0TDsxP5025388
	for perforce@freebsd.org; Mon, 29 Jan 2007 13:54:59 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Mon, 29 Jan 2007 13:54:59 GMT
Message-Id: <200701291354.l0TDsxP5025388@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 113667 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2007 13:55:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=113667

Change 113667 by rdivacky@rdivacky_witten on 2007/01/29 13:54:58

	We dont have to lock emul_lock in exit_group() because em->shared
	cannot change (because its referenced by curthread). This fixes
	a LOR caused by acquiring emul_shared_lock while holding emul_lock.
	While here fix typo in comment.

Affected files ...

.. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#53 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#53 (text+ko) ====

@@ -1617,7 +1617,7 @@
 #endif
 
 	if (linux_use26(td)) {
-		td_em = em_find(td->td_proc, EMUL_DOLOCK);
+		td_em = em_find(td->td_proc, EMUL_DONTLOCK);
 
 		KASSERT(td_em != NULL, ("exit_group: emuldata not found.\n"));
 
@@ -1635,11 +1635,10 @@
 		}
 
 		EMUL_SHARED_RUNLOCK(&emul_shared_lock);
-		EMUL_UNLOCK(&emul_lock);
 	}
 	/*
 	 * XXX: we should send a signal to the parent if
-	 * SIGNAL_EXIT_GROUP is set. We ignore that (temporrarily?)
+	 * SIGNAL_EXIT_GROUP is set. We ignore that (temporarily?)
 	 * as it doesnt occur often.
 	 */
 	exit1(td, W_EXITCODE(args->error_code, 0));