Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Jun 2018 12:55:50 -0600
From:      Brad Davis <brd@FreeBSD.org>
To:        rgrimes@freebsd.org
Cc:        Kyle Evans <kevans@freebsd.org>, "src-committers" <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r334617 - in head: . etc
Message-ID:  <1528138550.3632147.1396107464.614818A8@webmail.messagingengine.com>
In-Reply-To: <201806041847.w54IlCUu097084@pdx.rh.CN85.dnsmgr.net>
References:  <201806041847.w54IlCUu097084@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 4, 2018, at 12:47 PM, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
> > On Mon, Jun 4, 2018, at 10:57 AM, Rodney W. Grimes wrote:
> > > > On Mon, Jun 4, 2018, at 9:29 AM, Rodney W. Grimes wrote:
> > > > > [ Charset UTF-8 unsupported, converting... ]
> > > > > > On Mon, Jun 4, 2018 at 10:17 AM, Brad Davis <brd@freebsd.org> wrote:
> > > > > > > Author: brd
> > > > > > > Date: Mon Jun  4 15:17:24 2018
> > > > > > > New Revision: 334617
> > > > > > > URL: https://svnweb.freebsd.org/changeset/base/334617
> > > > > > >
> > > > > > > Log:
> > > > > > >   Move /sys symlink creating out of etc/Makefile.
> > > > > > >
> > > > > > >   This is prep for etc/Makefile going away.
> > > > > > >
> > > > > > >   Approved by:  bapt (mentor)
> > > > > > >
> > > > > > 
> > > > > > Woah, woah, woah, woah. =) May I ask what your plan for etc/Makefile
> > > > > > is? Some of the NO_ROOT stuff there seems to be terribly broken and
> > > > > > needs to be fixed; this was on my 'some day to fix' list.
> > > > > 
> > > > > Yes please, much more information here.  I use some of the targets
> > > > > in src/etc/Makefile such as distribution:
> > > > 
> > > > All the config files need to be pushed back next to the source they belong to.
> > > 
> > > That is fine, but there is stuff other than config files, how do you plan
> > > to handle that?
> > 
> > Moving them as appropriate just like the above..
> 
> So another words you have no plan yet?

It is largely done here:

https://github.com/brd/freebsd/tree/etc-DIR/etc

I am working on stragglers..

> > > > What do you use these targets for?
> > > 
> > > Building custom installation sets, building nfs shares.
> > 
> > OK, what commands specifically are you calling in etc/ directly and why?
> 
> I said in my first reply specifically distribution:
> 
> > 
> > I would expect the targets in the root of the src tree would handle that stuff for you?
> 
> hierarchy: may

But why do you run them yourself?

> > > > > I believe there are also other external consumers of this.
> > > > 
> > > > Such as?
> > > 
> > > Iirc some of the make release stuff calls into here, but that
> > > may of changed to use src/Makefile targets.  distrib-dirs comes
> > > to mind.
> > 
> > Sure, but those can go away or be updated as needed..
> 
> So again, no plan yet?

Most of them are gone, I am still in progress on some of it.  See the github branch above.

My testing is all done by building release VMs and comparing them against a VM built from the last merge from HEAD.  So I will update the release stuff as I go.  It is my responsibility to keep the release stuff working as I change these.


Regards,
Brad Davis



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1528138550.3632147.1396107464.614818A8>