From owner-freebsd-arch@FreeBSD.ORG Mon Apr 7 18:48:34 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9F85106566B; Mon, 7 Apr 2008 18:48:34 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.72]) by mx1.freebsd.org (Postfix) with ESMTP id A1E9C8FC22; Mon, 7 Apr 2008 18:48:34 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (asmtp006-s [10.150.69.69]) by smtpoutm.mac.com (Xserve/smtpout009/MantshX 4.0) with ESMTP id m37IYLRO010019; Mon, 7 Apr 2008 11:34:27 -0700 (PDT) Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mac.com (Xserve/asmtp006/MantshX 4.0) with ESMTP id m37IYJnh004932 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 7 Apr 2008 11:34:19 -0700 (PDT) Message-Id: <970636D8-F789-44EE-864D-49489D17D7D9@mac.com> From: Marcel Moolenaar To: d@delphij.net In-Reply-To: <47FA6833.8080904@delphij.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Date: Mon, 7 Apr 2008 11:33:56 -0700 References: <20080407181250.6733810656C9@hub.freebsd.org> <47FA6833.8080904@delphij.net> X-Mailer: Apple Mail (2.919.2) Cc: delphij@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [src] cvs commit: src/sys/ufs/ufs ufs_gjournal.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 18:48:34 -0000 On Apr 7, 2008, at 11:30 AM, LI Xin wrote: > Picking a random commit: > >> Index: src/sys/ufs/ufs/ufs_gjournal.c >> diff -u src/sys/ufs/ufs/ufs_gjournal.c:1.2 src/sys/ufs/ufs/ >> ufs_gjournal.c:1.3 >> --- src/sys/ufs/ufs/ufs_gjournal.c:1.2 Mon May 28 00:28:15 2007 >> +++ src/sys/ufs/ufs/ufs_gjournal.c Mon Apr 7 18:12:37 2008 >> @@ -82,7 +82,7 @@ >> cgbno = fsbtodb(fs, cgtod(fs, cg)); >> } >> if ((u_int)ino >= fs->fs_ipg * fs->fs_ncg) >> - panic("ffs_freefile: range: dev = %s, ino = %lu, fs = %s", >> + panic("ufs_gjournal_modref: range: dev = %s, ino = %lu, fs = %s", >> devtoname(dev), (u_long)ino, fs->fs_fsmnt); >> if ((error = bread(devvp, cgbno, (int)fs->fs_cgsize, NOCRED, >> &bp))) { >> brelse(bp); > > Is it suitable to use something like __func__ here? I mean, will > the usage of __func__ encouraged practice for base/kernel code or not? Speaking only for myself: yes, __func__ should be used at all times when the function name is needed... -- Marcel Moolenaar xcllnt@mac.com