From nobody Tue Apr 8 13:40:52 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZX6fX67N4z5sQGC; Tue, 08 Apr 2025 13:40:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZX6fX2BmMz3CsK; Tue, 08 Apr 2025 13:40:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YauNOnxcpachzrFE6msJAR3D4LiHNyN9RhsEjYScG14=; b=KFyuB9+JYbKoN1RaAZeHKzlvFo8La0TqXwkqI7YRXk6rHF0I2H1DSuy/V2E8wWss6j2a8q AzXNJLdT0k0ry+mGWO6CCd5XsMW+2+ogQXB5+pae0tjwirLOiKczDNS97DAWY8psc3zuJ8 Q7hmD6NIVNMTJORLVmyPb2ucLikzWXD2G/gL+ZHgBsh/KgEGGrrQIIOdEckpvVhZixIALv WWRmwAGZaT0RN+m1gpNkJFGzpL3eLUd35e+GCbKBrOblpz5pS0ZnUOSjQmmjSWMNT1OQMn ZZhquRNxrFn0K92uwqGzTJ7GWm9j5+Ua9cfn/WWcysXn6AHKW+iKXtCMvp98cg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744119652; a=rsa-sha256; cv=none; b=Z3mEXpSe9oozSdQZyIg/oK9L9sz64f1ksl1sp4E5Ep/tbli8ZMeFYjJse/lDCvp1Q5B5hD 1X7KB/PkMp/jCrDrAaF1n2ZGqh9gLlWha7qigwadBA/PtQ75v3Adn+qy6mzHRPDEMXkkDf yloDJADfVpgQcoPavRsSjUuaw19TOmYjCT+p9HG0R9I1r7ixDO2RXzgXZK9XM1Ey9x4//a +19L+ANzt3B2kBGi/Gx9hvA6Fsi3V55kQRzzVQ2nbQ5fFz2t5RyFgo8PA3lgL5f5r7ALJP nanv2O+Cja0zYQ71CmLLBaS6yl46FTtgzdymD44cxgUzTBFZrALwifojSv5QoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YauNOnxcpachzrFE6msJAR3D4LiHNyN9RhsEjYScG14=; b=PSZ4oKbMKnQ3EqTORfYtZ/lYC7AIuWL36u630c6rn3kIIRGIRX0d4cVZrkPwpbF35wtCSp P0R4MXDd7eOunW/0qUnKAtErgCe1yK8bVzfhwCWzqvEhOVB2tGEdQS85OpH1KVdALsEcJY HeN7mIp3ldwGXHkfinZlPw5KgOeU3ZNDA4LYY5H6teDR5RDRHUOtqfX//GDpHwTH+qGEXb rWkGC7zsPoDMGTWhWZTRw0Wf6st1HDlVLbDTnl7gESKSYIOSn8BMCRIWIj0Buse0HMSifJ ghfbU14hfBJZWVRqPdKyJFnJQNYSvZ7CwmPnFsSVDlSZ+xGAtWSvsDEW8CDerg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZX6fX1dWNzbCv; Tue, 08 Apr 2025 13:40:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 538DeqfA032099; Tue, 8 Apr 2025 13:40:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 538DeqYi032096; Tue, 8 Apr 2025 13:40:52 GMT (envelope-from git) Date: Tue, 8 Apr 2025 13:40:52 GMT Message-Id: <202504081340.538DeqYi032096@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 62b6d8c62598 - stable/14 - smbios: Print an error on memory map failure on identify List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 62b6d8c62598afa6bd4e48145d21952833be47b0 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=62b6d8c62598afa6bd4e48145d21952833be47b0 commit 62b6d8c62598afa6bd4e48145d21952833be47b0 Author: Olivier Certner AuthorDate: 2025-03-03 08:50:49 +0000 Commit: Olivier Certner CommitDate: 2025-04-08 13:38:24 +0000 smbios: Print an error on memory map failure on identify Consistently with what the probe and attach methods are doing. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation (cherry picked from commit 3907feff7ab732b918ba3f5993e7a6718fffea14) --- sys/dev/smbios/smbios.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/dev/smbios/smbios.c b/sys/dev/smbios/smbios.c index cd9a0eefb9f9..f87d2cfee403 100644 --- a/sys/dev/smbios/smbios.c +++ b/sys/dev/smbios/smbios.c @@ -118,8 +118,10 @@ smbios_identify (driver_t *driver, device_t parent) return; ptr = pmap_mapbios(addr, map_size); - if (ptr == NULL) + if (ptr == NULL) { + printf("smbios: Unable to map memory.\n"); return; + } if (map_size == sizeof(*eps3)) { eps3 = ptr; length = eps3->length;