Date: Tue, 11 May 2004 11:15:54 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/led led.h Message-ID: <20040511181554.GA13486@dragon.nuxi.com> In-Reply-To: <20040511100208.C75906@root.org> References: <20040510115040.0C9B516A53A@hub.freebsd.org> <20040511100208.C75906@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote: > On Mon, 10 May 2004, Maxime Henrion wrote: > > Modified files: > > sys/dev/led led.h > > Log: > > - Remove the __FBSDID and put the $FreeBSD$ tag in the comment above, > > so that including this file more than once works. .. > Do we even want __FBSDID in .h files? It doesn't seem to make sense since > it's not a compilation unit (i.e. no linkage). It actually does make sense, as a header's contents does wind up in a .o eventually :-) And header contents can be the cause of problems as much as a .c file. There is no problem having multiple __FBSDID in either a.out or ELF objects. That said, its not something we have agreement for [that I know of]. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040511181554.GA13486>