From owner-freebsd-net@freebsd.org Wed Aug 16 13:00:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01088DDA9B9 for ; Wed, 16 Aug 2017 13:00:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E34BB825EE for ; Wed, 16 Aug 2017 13:00:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7GD0GdT069294 for ; Wed, 16 Aug 2017 13:00:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 221418] FreeBSD 10.4-PRERELEASE fails to build on systems using 32 bit time_t since r322315. Date: Wed, 16 Aug 2017 13:00:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jau@iki.fi X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 13:00:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221418 --- Comment #3 from jau@iki.fi --- To Conrad I have to point out that truncating INT64_MIN to 32 bits might produce INT32_MIN on a big endian system. On a little endian platform the type cast invariably produces a plain zero (0). Concerning my using CHAR_BIT instead of plain numeric 8 I have to say I like portability enough to assume someone some day might wish to use FreeBSD on a system which does not use the 8/16/32/64 bits basic data units division our contemporary systems use. Maybe one day there is a reason to run FreeBSD on a system using 9/18/36 data unit division like in the old PDP-10 or IBM 7094. When there is no real reason to use minimum time_t it is in my opinion really much better to use -(SYNCOOKIE_LIFETIME + 1) as done in the fix 322454. Thanks Michael! --=20 You are receiving this mail because: You are the assignee for the bug.=