From owner-freebsd-hackers@FreeBSD.ORG Wed Jul 16 21:38:14 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88C0D848 for ; Wed, 16 Jul 2014 21:38:14 +0000 (UTC) Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 701702696 for ; Wed, 16 Jul 2014 21:38:14 +0000 (UTC) Received: from zeppelin.tachypleus.net (lasr-ap-1.uchicago.edu [128.135.70.188]) (authenticated bits=0) by c.mail.sonic.net (8.14.9/8.14.9) with ESMTP id s6GLc3F0017147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Wed, 16 Jul 2014 14:38:10 -0700 Message-ID: <53C6F0B7.1030608@freebsd.org> Date: Wed, 16 Jul 2014 14:37:59 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Subject: Re: Expanding on NO_ROOT: Categorizing installed files References: <20140716170758.GE60425@spindle.one-eyed-alien.net> <20140716195707.GH60425@spindle.one-eyed-alien.net> In-Reply-To: <20140716195707.GH60425@spindle.one-eyed-alien.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-ID: C;sh8fdzEN5BGYnk2zUc16mQ== M;0p5TezEN5BGYnk2zUc16mQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2014 21:38:14 -0000 On 07/16/14 12:57, Brooks Davis wrote: > On Wed, Jul 16, 2014 at 12:13:48PM -0700, Sean Fagan wrote: >> On Jul 16, 2014, at 10:07 AM, Brooks Davis wrote: >> >>> The vast majorify of the diff is make debugging garbage that looks like >>> it was committed by accident. I won't provided any detailed review >>> of the current patch except to say that there are a lot of apparently >>> redundent instances of setting META_CATEGORY in Makefiles and still >>> quite a lot of instances of .EXPORTVAR: META_CATEGORY. >> Okay. Again, my apologies about that; I've excised it, and removed all >> of the EXPORTVAR directives, even the ones that had been commented out. >> (Note that the patch includes a change to xinstall, that is commented out; that's >> because I think I still like the concept of it, to at least some degree, and didn't >> want to forget where I put it. But it *is* commented out, and so the functionality >> is simply not there.) >> >> Without my idiotic error, the diff is much smaller -- just under 50,000 bytes. However, >> rather than include it again, I've replaced the file at http://earth.kithrup.com/~sef/auto-diffs.txt >> for everyone's perusal. > Some comments with limited context: > > In Makefile.inc1 you write: > > LIB32WMAKEENV+= META_CATEGORY=compat32 > Picking a random example: how is this different/better than the existing DISTRIBUTION variable? -Nathan