From owner-svn-src-all@FreeBSD.ORG Thu Jan 24 04:54:53 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E26E7DD4; Thu, 24 Jan 2013 04:54:53 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id D416470E; Thu, 24 Jan 2013 04:54:53 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r0O4sroI094481; Thu, 24 Jan 2013 04:54:53 GMT (envelope-from yongari@svn.freebsd.org) Received: (from yongari@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r0O4srUg094480; Thu, 24 Jan 2013 04:54:53 GMT (envelope-from yongari@svn.freebsd.org) Message-Id: <201301240454.r0O4srUg094480@svn.freebsd.org> From: Pyun YongHyeon Date: Thu, 24 Jan 2013 04:54:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r245870 - head/sys/dev/bge X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2013 04:54:54 -0000 Author: yongari Date: Thu Jan 24 04:54:53 2013 New Revision: 245870 URL: http://svnweb.freebsd.org/changeset/base/245870 Log: bge_attach() can fail before attaching mii(4). So make sure to check bge_miibus before detaching mii(4). Modified: head/sys/dev/bge/if_bge.c Modified: head/sys/dev/bge/if_bge.c ============================================================================== --- head/sys/dev/bge/if_bge.c Thu Jan 24 03:33:15 2013 (r245869) +++ head/sys/dev/bge/if_bge.c Thu Jan 24 04:54:53 2013 (r245870) @@ -3899,9 +3899,9 @@ bge_detach(device_t dev) if (sc->bge_tq) taskqueue_drain(sc->bge_tq, &sc->bge_intr_task); - if (sc->bge_flags & BGE_FLAG_TBI) { + if (sc->bge_flags & BGE_FLAG_TBI) ifmedia_removeall(&sc->bge_ifmedia); - } else { + else if (sc->bge_miibus != NULL) { bus_generic_detach(dev); device_delete_child(dev, sc->bge_miibus); }