From owner-cvs-src@FreeBSD.ORG Wed Aug 25 22:59:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B414A16A4CE; Wed, 25 Aug 2004 22:59:42 +0000 (GMT) Received: from green.homeunix.org (pcp04368961pcs.nrockv01.md.comcast.net [69.140.212.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 540FE43D41; Wed, 25 Aug 2004 22:59:42 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i7PMxeHJ081785; Wed, 25 Aug 2004 18:59:40 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i7PMxeET081784; Wed, 25 Aug 2004 18:59:40 -0400 (EDT) (envelope-from green) Date: Wed, 25 Aug 2004 18:59:39 -0400 From: Brian Fundakowski Feldman To: "David E. O'Brien" Message-ID: <20040825225939.GM77326@green.homeunix.org> References: <200408251828.i7PISFtH078796@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200408251828.i7PISFtH078796@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include in_cksum.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 22:59:43 -0000 On Wed, Aug 25, 2004 at 06:28:15PM +0000, David E. O'Brien wrote: > obrien 2004-08-25 18:28:15 UTC > > FreeBSD src repository > > Modified files: > sys/i386/include in_cksum.h > Log: > Fix a bug in in_cksum_hdr w/o -O. > > The C code assumes that the carry bit is always kept from the previous > operation. However, the pointer indexing requires another add operation. > Thus, the carry bit from the first operation is tromped over by the > "addl" operation that ends up following it, so the "adcl" that follows > that has no effect because the carry bit is cleared before it. > The result is checksum failure on received packets. Good job! Did you see any similar bugs in other in-line asm you might have glanced at? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\