From owner-p4-projects@FreeBSD.ORG  Tue May 16 23:46:45 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BFCAB16A4FD; Tue, 16 May 2006 23:46:45 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 85A4116A4A7
	for <perforce@freebsd.org>; Tue, 16 May 2006 23:46:45 +0000 (UTC)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 523D143D46
	for <perforce@freebsd.org>; Tue, 16 May 2006 23:46:45 +0000 (GMT)
	(envelope-from kmacy@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4GNkRBS008501
	for <perforce@freebsd.org>; Tue, 16 May 2006 23:46:27 GMT
	(envelope-from kmacy@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4GNkRgw008498
	for perforce@freebsd.org; Tue, 16 May 2006 23:46:27 GMT
	(envelope-from kmacy@freebsd.org)
Date: Tue, 16 May 2006 23:46:27 GMT
Message-Id: <200605162346.k4GNkRgw008498@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	kmacy@freebsd.org using -f
From: Kip Macy <kmacy@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 97308 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 May 2006 23:46:46 -0000

http://perforce.freebsd.org/chv.cgi?CH=97308

Change 97308 by kmacy@kmacy_storage:sun4v_rwbuf on 2006/05/16 23:46:14

	don't do unlocked reads of tsb

Affected files ...

.. //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#14 edit

Differences ...

==== //depot/projects/kmacy_sun4v/src/sys/sun4v/sun4v/tsb.c#14 (text+ko) ====

@@ -194,7 +194,6 @@
 	tsb_index = (va >> tsb_shift) & TSB_MASK(tsb);
 	entry = (tte_t *)TLB_PHYS_TO_DIRECT(tsb->hvtsb_pa + 2*tsb_index*sizeof(uint64_t));
 	
-	*(entry) = 0;
 	*(entry + 1) = 0;
 
 	membar(Sync);
@@ -213,7 +212,6 @@
 	for (tva = sva; tva < eva; tva += PAGE_SIZE) {
 		tsb_index = (tva >> tsb_shift) & tsb_mask;
 		entry = (tte_t *)TLB_PHYS_TO_DIRECT(tsb->hvtsb_pa + 2*tsb_index*sizeof(uint64_t));
-		*(entry) = 0;
 		*(entry + 1) = 0;
 	}
 
@@ -270,8 +268,6 @@
 
 	if ((tte_data = tsb_get_tte(&kernel_td[TSB4M_INDEX], va)) != 0)
 		goto done;
-	if ((tte_data = tsb_get_tte(&kernel_td[TSB8K_INDEX], va)) != 0)
-		goto done;
 
 	/*
 	 * handle user data