From owner-cvs-src@FreeBSD.ORG Fri Jan 27 03:36:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64AEA16A420; Fri, 27 Jan 2006 03:36:21 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42A6B43D76; Fri, 27 Jan 2006 03:36:12 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k0R3aBpU042203; Thu, 26 Jan 2006 20:36:11 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <43D9952D.3050800@samsco.org> Date: Thu, 26 Jan 2006 20:36:13 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jason Evans References: <200601270236.k0R2ai2x067283@repoman.freebsd.org> <20060127025150.GA57825@nagual.pp.ru> <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> In-Reply-To: <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Andrey Chernov , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2006 03:36:21 -0000 Jason Evans wrote: > On Jan 26, 2006, at 6:51 PM, Andrey Chernov wrote: > >> I worry about my system performance. Could you please make all >> statistics >> and debug code conditional, debending on some flags which could be >> set as >> malloc options? Even in case this is a test period now, some people >> perhaps don't want some tests. It is much easy to turn some tests off >> via >> malloc options than to comment out manually corresponding malloc.c >> defines >> after each cvsup. > > > Unfortunately, run-time checks for the debugging features are > expensive, since the debugging code is scattered throughout malloc.c. > This pretty much mandates compile-time configuration, for performance > reasons. > > I can disable statistics and debugging, if there's a general consensus > to do so. How much performance difference is the debug/ stats code > making for you? I've only been disabling debug/stats for benchmarking > purposes, so I don't have a good feel for how much it impacts overall > system performance. > > Thanks, > Jason > I think that it's all just fine the way it is. If you can refactor things so that it's convenient and non-intrusive to make the debugging controllable at runtime, that's great, but it's not something to loose sleep over. Scott