From owner-svn-src-all@FreeBSD.ORG  Tue Aug 12 13:28:47 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3230CFF
 for <svn-src-all@freebsd.org>; Tue, 12 Aug 2014 13:28:47 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 06D112EB6
 for <svn-src-all@freebsd.org>; Tue, 12 Aug 2014 13:28:47 +0000 (UTC)
Received: from ache (uid 542) (envelope-from ache@FreeBSD.org) id 6811
 by svn.freebsd.org (DragonFly Mail Agent v0.9+);
 Tue, 12 Aug 2014 13:28:46 +0000
From: Andrey A. Chernov <ache@FreeBSD.org>
Date: Tue, 12 Aug 2014 13:28:46 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r269875 - head/lib/libpam/modules/pam_opie
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Message-Id: <53ea168e.6811.1ab9cea0@svn.freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2014 13:28:47 -0000

Author: ache
Date: Tue Aug 12 13:28:46 2014
New Revision: 269875
URL: http://svnweb.freebsd.org/changeset/base/269875

Log:
  According to opie code and even direct mention in opie(4) challenge buffer
  size must be OPIE_CHALLENGE_MAX + 1, not OPIE_CHALLENGE_MAX
  
  Reviewed by:    des
  MFC after:      1 week

Modified:
  head/lib/libpam/modules/pam_opie/pam_opie.c

Modified: head/lib/libpam/modules/pam_opie/pam_opie.c
==============================================================================
--- head/lib/libpam/modules/pam_opie/pam_opie.c	Tue Aug 12 13:13:11 2014	(r269874)
+++ head/lib/libpam/modules/pam_opie/pam_opie.c	Tue Aug 12 13:28:46 2014	(r269875)
@@ -62,7 +62,7 @@ pam_sm_authenticate(pam_handle_t *pamh, 
 	struct passwd *pwd;
 	int retval, i;
 	const char *(promptstr[]) = { "%s\nPassword: ", "%s\nPassword [echo on]: "};
-	char challenge[OPIE_CHALLENGE_MAX];
+	char challenge[OPIE_CHALLENGE_MAX + 1];
 	char principal[OPIE_PRINCIPAL_MAX];
 	const char *user;
 	char *response;