From owner-freebsd-arch@FreeBSD.ORG  Sat Feb  9 09:28:53 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id C040851E
 for <freebsd-arch@freebsd.org>; Sat,  9 Feb 2013 09:28:53 +0000 (UTC)
 (envelope-from christoph.mallon@gmx.de)
Received: from mout.gmx.net (mout.gmx.net [212.227.17.20])
 by mx1.freebsd.org (Postfix) with ESMTP id 6009961
 for <freebsd-arch@freebsd.org>; Sat,  9 Feb 2013 09:28:53 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.34]) by mrigmx.server.lan
 (mrigmx002) with ESMTP (Nemesis) id 0MCeiK-1UCODG1FGE-009SSI for
 <freebsd-arch@FreeBSD.org>; Sat, 09 Feb 2013 10:28:52 +0100
Received: (qmail invoked by alias); 09 Feb 2013 09:28:45 -0000
Received: from p5B132F8B.dip.t-dialin.net (EHLO rotluchs.lokal) [91.19.47.139]
 by mail.gmx.net (mp034) with SMTP; 09 Feb 2013 10:28:45 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX195co0O0NJ51ooiTqkzoA7ODFyrOKZZBPlKoUqFVV
 KUnnnGuYINQiH3
Message-ID: <511616AC.8080306@gmx.de>
Date: Sat, 09 Feb 2013 10:28:12 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130129 Thunderbird/17.0.2
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: Proposal: Unify printing the function name in panic messages()
References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org>
 <51160E06.1070404@gmx.de> <5116121E.1010601@FreeBSD.org>
In-Reply-To: <5116121E.1010601@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: Kirk McKusick <mckusick@mckusick.com>, freebsd-arch@FreeBSD.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Feb 2013 09:28:53 -0000

On 09.02.2013 10:08, Andriy Gapon wrote:
> In any case, you just search the code for the message and that's it.

Often the messages contains parameters (%d, %s, ...) or are split into multiple lines to appease the ancient 80 columns god.
These make it harder to grep.
Having the /right/ name makes it easier to get to the right place.

> If this is a solution in search of a problem, then I don't like it, because it

The two problems this change solves are very simple:
- There are needlessly about a dozen different ways used to add the function name into the panic message.
  This change unifies it.
- All too often the name is wrong.
  This change gets it right every time without any manual and error-prone effort of somebody, who adds a use of PANIC().

> requires massive, if mostly mechanical, changes throughout the code.

I do not understand, what the problem is.
There are bugs and cumbersome code.
This simple changes solves it.

	Christoph