From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 5 09:30:24 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0627F16A4EB for ; Wed, 5 Jul 2006 09:30:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 045D543D5A for ; Wed, 5 Jul 2006 09:30:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k659ULoO072872 for ; Wed, 5 Jul 2006 09:30:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k659ULBo072871; Wed, 5 Jul 2006 09:30:21 GMT (envelope-from gnats) Resent-Date: Wed, 5 Jul 2006 09:30:21 GMT Resent-Message-Id: <200607050930.k659ULBo072871@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Jeremy Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FA4116A4DA for ; Wed, 5 Jul 2006 09:29:03 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail12.syd.optusnet.com.au (mail12.syd.optusnet.com.au [211.29.132.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22D4843D53 for ; Wed, 5 Jul 2006 09:29:01 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail12.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k659SxgY014398 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Wed, 5 Jul 2006 19:29:00 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k659SxQM001308 for ; Wed, 5 Jul 2006 19:28:59 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k659Sxrn001307; Wed, 5 Jul 2006 19:28:59 +1000 (EST) (envelope-from peter) Message-Id: <200607050928.k659Sxrn001307@turion.vk2pj.dyndns.org> Date: Wed, 5 Jul 2006 19:28:59 +1000 (EST) From: Peter Jeremy To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/99800: [PATCH] Add support for profiling multiple executions X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter Jeremy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2006 09:30:24 -0000 >Number: 99800 >Category: bin >Synopsis: [PATCH] Add support for profiling multiple executions >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jul 05 09:30:21 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Peter Jeremy >Release: FreeBSD 6.1-STABLE amd64 >Organization: n/a >Environment: System: FreeBSD turion.vk2pj.dyndns.org 6.1-STABLE FreeBSD 6.1-STABLE #19: Tue Jul 4 17:56:20 EST 2006 root@turion.vk2pj.dyndns.org:/usr/obj/usr/src/sys/turion amd64 >Description: gprof(1) has support for merging multiple gmon.out files but the name 'NAME.gmon' is hard-wired in the profiling code and any existing NAME.gmon file is over-written. The patch below allows a process to create 'NAME.PID.gmon' by creating an enviroment variable "PROFIL_USE_PID". >How-To-Repeat: Code inspection shows that NAME.gmon is hard-coded and truncated. >Fix: Index: lib/libc/gmon/gmon.c =================================================================== RCS file: /usr/ncvs/src/lib/libc/gmon/gmon.c,v retrieving revision 1.20 diff -u -r1.20 gmon.c --- lib/libc/gmon/gmon.c 16 Oct 2004 06:32:43 -0000 1.20 +++ lib/libc/gmon/gmon.c 21 May 2006 19:11:14 -0000 @@ -174,7 +174,11 @@ } moncontrol(0); - snprintf(outname, sizeof(outname), "%s.gmon", _getprogname()); + if (getenv("PROFIL_USE_PID")) + snprintf(outname, sizeof(outname), "%s.%d.gmon", + _getprogname(), getpid()); + else + snprintf(outname, sizeof(outname), "%s.gmon", _getprogname()); fd = _open(outname, O_CREAT|O_TRUNC|O_WRONLY, 0666); if (fd < 0) { _warn("_mcleanup: %s", outname); >Release-Note: >Audit-Trail: >Unformatted: