From owner-freebsd-sysinstall@FreeBSD.ORG Mon Oct 24 08:56:30 2011 Return-Path: Delivered-To: freebsd-sysinstall@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D47AB106566C; Mon, 24 Oct 2011 08:56:30 +0000 (UTC) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.freebsd.org (Postfix) with ESMTP id 920508FC0C; Mon, 24 Oct 2011 08:56:30 +0000 (UTC) Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3]) by phk.freebsd.dk (Postfix) with ESMTP id 22F5A5DC8; Mon, 24 Oct 2011 08:56:29 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.14.5/8.14.5) with ESMTP id p9O8uSQ9021149; Mon, 24 Oct 2011 08:56:28 GMT (envelope-from phk@phk.freebsd.dk) To: Nathan Whitehorn From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 23 Oct 2011 15:08:54 EST." <4EA47456.7090008@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Date: Mon, 24 Oct 2011 08:56:28 +0000 Message-ID: <21148.1319446588@critter.freebsd.dk> Cc: freebsd-bugs@freebsd.org, freebsd-sysinstall@freebsd.org Subject: Re: bin/161926: bsdinstall(8): disk layout trouble X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2011 08:56:30 -0000 In message <4EA47456.7090008@freebsd.org>, Nathan Whitehorn writes: >On 10/23/11 13:15, Poul-Henning Kamp wrote: >There's not actually too much need for them, and so they never seemed >pressing. Pressing control-C/choosing "cancel"/etc. will either skip >steps that can be returned to later (post-extraction) or return to the >beginning of the installation, which is where you already were, Let me just note that neither the overall structure nor where I would end up by pressing Ctrl-C was not even remotely obvious to this particular user. >>>> Active partition is the last one created ? >>>> There is no place I can see it ? >>>> There is no place I can change it ? >>> Active partition is the last bootable (e.g. freebsd) partition you >>> created, yes. >> That is *totally* bogus, at the very least, make it the first one. > >The UI problem is actually hard, and the correct solution without a UI >solution is non-obvious. The usual use case, where only one MBR >partition of type freebsd is added, works perfectly well. I'll try to >find a reasonable solution to this, but have very little time at the >moment -- patches would be much appreciated. The fact that is is hard to do right, seems an incredibly lousy excuse for doing something totally counter-intutive. Systems with more than one MBR partition are quite common in the wild in my experience. How about you set the active flag on whatever parition contains the / filesystem as part of final cleanup ? I'm not going to be sending patches: I solved this problem once according to the priorities at the time, you get to solve it this time :-) My input should simply count as a single old grumbling fart, and if you think he is totally out of touch, you get to ignore him. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.