From owner-svn-src-head@FreeBSD.ORG Fri Oct 8 01:03:31 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 476FA1065672; Fri, 8 Oct 2010 01:03:31 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3507A8FC08; Fri, 8 Oct 2010 01:03:31 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o9813VrC073286; Fri, 8 Oct 2010 01:03:31 GMT (envelope-from emaste@svn.freebsd.org) Received: (from emaste@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o9813VbC073284; Fri, 8 Oct 2010 01:03:31 GMT (envelope-from emaste@svn.freebsd.org) Message-Id: <201010080103.o9813VbC073284@svn.freebsd.org> From: Ed Maste Date: Fri, 8 Oct 2010 01:03:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r213537 - head/sys/dev/usb/wlan X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2010 01:03:31 -0000 Author: emaste Date: Fri Oct 8 01:03:30 2010 New Revision: 213537 URL: http://svn.freebsd.org/changeset/base/213537 Log: In r207768 I silenced a console warning from rum(4). There was legitimate opposition to the change, since really we need to implement missing functionality in drivers or the 802.3 layer. For now, restore a reminder message for a missing rum_update_mcast, but print it only once. Modified: head/sys/dev/usb/wlan/if_rum.c Modified: head/sys/dev/usb/wlan/if_rum.c ============================================================================== --- head/sys/dev/usb/wlan/if_rum.c Fri Oct 8 00:44:53 2010 (r213536) +++ head/sys/dev/usb/wlan/if_rum.c Fri Oct 8 01:03:30 2010 (r213537) @@ -1819,8 +1819,12 @@ rum_update_promisc(struct ifnet *ifp) static void rum_update_mcast(struct ifnet *ifp) { + static int warning_printed; - /* XXX do nothing? */ + if (warning_printed == 0) { + if_printf(ifp, "need to implement %s\n", __func__); + warning_printed = 1; + } } static const char *