From owner-freebsd-gnome@FreeBSD.ORG Sat Feb 26 08:32:57 2005 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7FE016A4CE for ; Sat, 26 Feb 2005 08:32:56 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8197843D64 for ; Sat, 26 Feb 2005 08:32:56 +0000 (GMT) (envelope-from marcus@FreeBSD.org) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) j1Q8XFKp040889; Sat, 26 Feb 2005 03:33:15 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Jose M Rodriguez In-Reply-To: <200502250922.17098.josemi@freebsd.jazztel.es> References: <200502250756.j1P7uEn0023933@freefall.freebsd.org> <200502250922.17098.josemi@freebsd.jazztel.es> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-aHczTdnBBU1/gjLvuKaY" Organization: FreeBSD, Inc. Date: Sat, 26 Feb 2005 03:32:33 -0500 Message-Id: <1109406753.61886.24.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 FreeBSD GNOME Team Port cc: FreeBSD GNOME Users Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package script X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Feb 2005 08:32:57 -0000 --=-aHczTdnBBU1/gjLvuKaY Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, 2005-02-25 at 09:22 +0100, Jose M Rodriguez wrote: > El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribi=F3: > > Synopsis: [PATCH] www/firefox: new mozilla.sh and package script > > > > State-Changed-From-To: open->closed > > State-Changed-By: marcus > > State-Changed-When: Fri Feb 25 07:52:11 GMT 2005 > > State-Changed-Why: > > I've committed some of this. What I didn't commit was the PIS work.=20 > > While the framework might be there to embed RC scripts into Mozilla > > and Firefox, I don't think this is the right place to add sound > > server support. I don't want to get bogged down in a lot of local > > scripts that make these ports unsupportable, or in violation of our > > license agreement with Mozilla. > > >=20 > Please, consider the cleanhome moz_pis for firefox. This makes firefox=20 > upgrades don't be hurt by local profile. This could be useful. However, I have some concerns, and the comments in the script didn't help. This removes the pluginreg.dat every time Firefox is started. Will that have any negative effects? What about performance? Couldn't this be wrapped about the -ot comparison as well? Also, you have a typo. The file is XUL.mfasl, not XUL.mfast. Other than that, this is a very clever script, and will probably make upgrades more painless. >=20 > > As for your pkg-[de]install work, I didn't see a real advantage of > > moving some of these things out into scripts. Plus, it looks like > > your pkg-deinstall would nuke all of browser_plugins. > > >=20 > Only make this happens from packages, not only from ports. As an=20 > example, you get the java plugin working when you install the=20 > firefox/mozilla package. I'll investigate the pkg-deinstall. I think we'll revisit this for 1.1. Thus far, no one has complained, and since the 1.0.1 update went fairly smoothly, I'd rather not rock the boat. Please resubmit a patch for this when you figure out the pkg-deinstall problem. Joe >=20 > > The rest of patches looked okay, and were merged. In the future, > > please do all diffs frome one level above the directory in question.=20 > > For example: > > > > diff -ruN firefox.orig firefox > > > > This makes patching much easier. Also, please don't submit diffs > > against CVS versions. If a new version hasn't been released, either > > wait, or submit the diff against the current version in the ports > > tree. Thanks. > > >=20 > -- > josemi > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D75816 >=20 >=20 --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-aHczTdnBBU1/gjLvuKaY Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBCIDQhb2iPiv4Uz4cRAo43AKCsw1mGw/kiGDVEPJiCwDq/l7zyPwCgrMG0 /c0hooAA69vThhQKQHEjPp8= =oRD5 -----END PGP SIGNATURE----- --=-aHczTdnBBU1/gjLvuKaY--