From nobody Wed Aug 5 19:03:25 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFfvK394Hz6n0SY for ; Wed, 05 Aug 2026 19:03:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFfvK2Slhz3vpy for ; Wed, 05 Aug 2026 19:03:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785956605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U/C25IokL5oNuW5G3gHCtP49k1FaxKHB0oU8vUAqMoc=; b=twyo+eMjrm7Px9J7vvJV8H1Vdv1lK9Uq72p0nncJl7c18kFIWIk7DORCHwKbqsQlyUNrl0 dbW4nk3bhxgBk3NZ/4HQ0oUj4W1GcdQV9jZ+XWEd6pswPIkh3mlPz2xMLX84U5/UeA9rRY jznmbbVN0mQa7olfrKNGRAfY6yyClfE3IErSRGNc8H/alvbBZZ94I9pMpTUGOWhP6Qi8Na GBJzZD4Je6q7m3DfESfjUmzKrEObxRJqfL78YgZ4aaFLaWZeTng+HpiEGLeULyyuUKYuT/ GjpgeGZjT8wP/g+wxfaro5XWKGq4Tpo/S5S7jXGxj4vINL46htnnHNlnVFB4IA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785956605; a=rsa-sha256; cv=none; b=qGoQgcwGNvOjrxsF2orYEEB1mUooAbLbc0vMqrPpiumEIgXrLc/UTV7XZNvGAj8pRqVJxy 4/RRiLrXuBgOMSYBQBvwN7ovhjeVZrHsY/87heKVfJc3dEusse9w6X7e0slEhUYJ8I1r7E WYyLi4s15F4URlP093+VemWQ5wUuwzam7okmfRajMpxSWStxU0mIURNvRPoemJe+a+B8O4 nsD/d5kKdPZnGnqUZkwjJSUHvmiKhZLULICqHRKD4gPhaCeSRlavKBfNBTqPN7dYejDLcW 04R6w4RCOhXEJYq5aHCBjCq4FoHcojiaFHfv4Ir+aZAd/r0Fa8TINxtxpFgU7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785956605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U/C25IokL5oNuW5G3gHCtP49k1FaxKHB0oU8vUAqMoc=; b=OxdadGgURw8gMHcsg3DOb2wwKgEET0qXlK/BXUBtF94bDgN4e6AiWJrKvXlobEIcqlAAmb iQlxf51n42Gw5vRZ3ZUenICqzyU+xnb1oWoxotgVAa1M8EBSu8QA0n6mvndW/h1x6jQtVo yTAEIgbBk3TM0+gXcmJqO8T8GXzYxBhfiLX1DKCdqk9IrvLJGMnVoJLgEfYeNJ/MHRCu7B vDWs+JWavk++N32HtTvTCPt5NKozQS0TwBj43v/cgxQGyYpD2C/7D63ke23YnaqwD3l/44 QWoJHHL5DMLO5ZIca0adzCgVFGo71rXcBBTIAgYRFGSI3EwmPpInxBOPOIOxhQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFfvK0sHSznFC for ; Wed, 05 Aug 2026 19:03:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37b96 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 19:03:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 4dc196233e40 - main - bhyve: Fix assignment of *niov2 in split_iov() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4dc196233e406cd30b9b1936adb91381f6892a6a Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 19:03:25 +0000 Message-Id: <6a7388fd.37b96.52eebdc1@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=4dc196233e406cd30b9b1936adb91381f6892a6a commit 4dc196233e406cd30b9b1936adb91381f6892a6a Author: Mark Johnston AuthorDate: 2026-08-05 18:58:32 +0000 Commit: Mark Johnston CommitDate: 2026-08-05 18:58:32 +0000 bhyve: Fix assignment of *niov2 in split_iov() niov2 returns the number of entries in the iovec starting at offset "offset". Here we are unconditionally setting it to 1, which of course isn't right. Fixes: a28cf86c4171 ("bhyve/virtio: Rework iovec handling functions for efficiency and clarity") Reported by: Claude and Ada Logics Reviewed by: Hans Rosenfeld MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58625 --- usr.sbin/bhyve/iov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/iov.c b/usr.sbin/bhyve/iov.c index aadea1d67933..637b1f4be304 100644 --- a/usr.sbin/bhyve/iov.c +++ b/usr.sbin/bhyve/iov.c @@ -71,8 +71,8 @@ split_iov(struct iovec *iov, size_t *niov1, size_t offset, size_t *niov2) } /* The entry iov[count] needs to be split. */ - *niov1 = count + 1; *niov2 = *niov1 - count; + *niov1 = count + 1; memmove(&iov[count + 1], &iov[count], sizeof(struct iovec) * (*niov2)); iov[count].iov_len = resid; iov[count + 1].iov_base = (char *)iov[count].iov_base + resid;