From owner-freebsd-arch@FreeBSD.ORG Wed Jan 21 14:20:57 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 208E51065975; Wed, 21 Jan 2009 14:20:57 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id BA8878FC22; Wed, 21 Jan 2009 14:20:55 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA07645; Wed, 21 Jan 2009 16:20:53 +0200 (EET) (envelope-from avg@icyb.net.ua) Message-ID: <49772F44.1030806@icyb.net.ua> Date: Wed, 21 Jan 2009 16:20:52 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.18 (X11/20081124) MIME-Version: 1.0 To: John Baldwin , "M. Warner Losh" References: <496C8C6A.2030708@icyb.net.ua> <20090115.110824.298933043.imp@bsdimp.com> <497088E6.4020908@icyb.net.ua> <200901210857.22204.jhb@freebsd.org> In-Reply-To: <200901210857.22204.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Archie Cobbs , freebsd-arch@freebsd.org Subject: Re: smb(4): address format X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 14:21:02 -0000 on 21/01/2009 15:57 John Baldwin said the following: > On Friday 16 January 2009 8:17:26 am Andriy Gapon wrote: >> on 15/01/2009 20:08 M. Warner Losh said the following: >>> The format that is preferred on FreeBSD is xxxxxxxx0b. That's the >>> format that the existing IIC bridge drivers use and deal with. I've >>> not looked at the SMB drivers, but I went through all the iic bridge >>> drivers in the 6.x time frame and made sure they were all consistent. >>> If I missed the smb drivers, that's my bad. >>> >>> I could find no evidence that there was a format that was more >>> preferred apart from the dozen data sheets that I'd read at the time >>> which used the xxxxxxx0b. >> What about the attached patch. >> It brings ichsmb in line with this format and also adds a simple check >> into smb(4). > > Commit! > I guess this would also need a note in UPDATING and some HEADS UP in current@. -- Andriy Gapon