From owner-svn-src-head@FreeBSD.ORG Tue Feb 10 22:10:48 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B1BA1065726 for ; Tue, 10 Feb 2009 22:10:48 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from mail-out1.fuse.net (mail-out1.fuse.net [216.68.8.175]) by mx1.freebsd.org (Postfix) with ESMTP id B8B918FC2C for ; Tue, 10 Feb 2009 22:10:47 +0000 (UTC) (envelope-from cokane@FreeBSD.org) X-CNFS-Analysis: v=1.0 c=1 a=gIS8vQCsamoA:10 a=w5tnKKSlJdEA:10 a=6I5d2MoRAAAA:8 a=LxPFicOcEEruJsllyeYA:9 a=PSuUN_CzHMxOVDkMoMAA:7 a=Sf4FbcmdLxMw3eMSe8VB4cqutgkA:4 a=LY0hPdMaydYA:10 a=6Xy3pLuTsEIY1HBv69QA:9 a=6bUljeqalFlxX5WB9PtN1eUG6tUA:4 a=rPt6xJ-oxjAA:10 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: gwout1 smtp.mail=cokane@FreeBSD.org; spf=softfail Received-SPF: softfail (gwout1: transitional domain FreeBSD.org does not designate 74.215.227.9 as permitted sender) Received: from [74.215.227.9] ([74.215.227.9:50388] helo=discordia) by gwout1 (envelope-from ) (ecelerity 2.2.2.37 r(28805/28810M)) with ESMTP id DE/9B-04546-66BF1994; Tue, 10 Feb 2009 17:10:46 -0500 Received: by discordia (Postfix, from userid 103) id B332635A7D6; Tue, 10 Feb 2009 17:10:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.31.1.6] (unknown [172.31.1.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id 4DE7135A7D5; Tue, 10 Feb 2009 17:10:37 -0500 (EST) From: Coleman Kane To: Marius Strobl In-Reply-To: <200902102154.n1ALsNCh005356@svn.freebsd.org> References: <200902102154.n1ALsNCh005356@svn.freebsd.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-bCSF3ePBY/bxd10a1Vyf" Organization: FreeBSD Project Date: Tue, 10 Feb 2009 17:09:47 -0500 Message-Id: <1234303787.10699.4.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188457 - head/sys/dev/bge X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2009 22:10:48 -0000 --=-bCSF3ePBY/bxd10a1Vyf Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2009-02-10 at 21:54 +0000, Marius Strobl wrote: > Author: marius > Date: Tue Feb 10 21:54:23 2009 > New Revision: 188457 > URL: http://svn.freebsd.org/changeset/base/188457 >=20 > Log: > Don't reset the PHY probe retry counter within the loop so > it will eventually terminate as intended. > =20 > Submitted by: Helen Zhang >=20 > Modified: > head/sys/dev/bge/if_bge.c >=20 > Modified: head/sys/dev/bge/if_bge.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/bge/if_bge.c Tue Feb 10 21:51:33 2009 (r188456) > +++ head/sys/dev/bge/if_bge.c Tue Feb 10 21:54:23 2009 (r188457) > @@ -2674,11 +2674,11 @@ bge_attach(device_t dev) > * if we get a conflict with the ASF firmware accessing > * the PHY. > */ > + trys =3D 0; > BGE_CLRBIT(sc, BGE_MODE_CTL, BGE_MODECTL_STACKUP); > again: > bge_asf_driver_up(sc); > =20 > - trys =3D 0; > if (mii_phy_probe(dev, &sc->bge_miibus, > bge_ifmedia_upd, bge_ifmedia_sts)) { > if (trys++ < 4) { >=20 I'm curious... I recent ran into a problem where this driver was not properly recovering from an ACPI resume event (under amd64 with some patches). I am curious if this patch might fix that problem... as the death happened somewhere around here. What example case did you use to discover this bug? --=20 Coleman Kane --=-bCSF3ePBY/bxd10a1Vyf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkmR+ycACgkQcMSxQcXat5cCJgCfcSG2qSKkgnxWLwe3oC/Mnkxp JngAn0uyMSsaDiMUwhpEKtNM/xFr4jo9 =6CH1 -----END PGP SIGNATURE----- --=-bCSF3ePBY/bxd10a1Vyf--