From nobody Wed Aug 20 13:14:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6Rkr51Grz64vrN; Wed, 20 Aug 2025 13:15:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6Rkr3Sq4z3Rxb; Wed, 20 Aug 2025 13:15:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755695700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2wPI7Y3PtPMuzMqfdJKUGYphEOfp1g2hHqC+swZo0mw=; b=VSIYtMAQCybfLGo5+Dh37xDulDhUfybLl/LdFpzjeZXxW57MS5MYLBqNfyKSst2sOo2TFY WnU7GJIw+AQNvDBW5lPnQLTxay62JIJ7bjLvL6qGmxplbrLm8L5W4KWjJkPoh5Y5Jwbqgh bRYRYnXLTAh7tz23yhMcRsdz8kIjswaT6sl9DmxVlFLbmeEIsFjRikHP1Z7sPYJnaJfcKa R6EcI8DK2e0UGYW21zI87hpdImOtzE/a1qSsL+4Jbtys9JlPK6XpXyBoHRm3H1YP4bF8tL Ev0FS4nHXIutUlA9xtT6d3nYRJor+gJP+A3e8zF/fQ1i9HGwi/HKT5MtPmf68A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755695700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2wPI7Y3PtPMuzMqfdJKUGYphEOfp1g2hHqC+swZo0mw=; b=rFIF43+dStb5n4d3GS6KO3Z3C7M7bPqraLf7uKUudlXKPjvxkMLHgWoc75ylsLOowUVTMW wmCB+QJVt9aniaGDKC2OgHhK4yJo34Mu2bXDQwu9UWq3Hyn2v3oIfM6E3rewvkNIgzG/wT 9xGYGbBumudiROgrmNBt1QJVNeIB0R42roxN/1TcT1NtBcwOU+wmAOZ0miCDxDivy+FNdP gz/PAcgQcgmnuIMuZnthfootSOLpKas2UtPqdmdWvSEC3igH4ouhJXzLI9l61Qq7zka9Fz dJwGQH/Cnjqi8FqXpsiGaNdPYmQXXauDH2+YqTDNVHph/YmeYezI8v/GZrcR9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755695700; a=rsa-sha256; cv=none; b=O52ogY1JtBfallqYlt+MoWiVrch3wTco88JvWTqgPqpt7rZf8GU63PLe7vyWAc83JJGrNG xke1m6FTp2nQtOiGpBApdUFhYouopJKwIudVkNyxNsIBy0VCEiFVHykUfUrwVXE/uwRXmO tWH38+efbkI/Ba1D25vxtzhM90yZQGz5BglbzFfor9FlXbp8Hr1BfNZipuPaJh2n4XSPVg iC6UJiSLuZsXAuLqcqeUPb9VaVZWKRg6c/lp/2XIeur1T7PGbNHKbN4xNhr1VVOtWo/Rb2 ikEXN2T/W90gCZ1hLIqPsvalJVVyIKb683FFki0/JfQD7BR3O6dgdgES3pgyjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:dcd8:8b69:c90b:430f] (unknown [IPv6:2601:5c0:4202:5670:dcd8:8b69:c90b:430f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c6Rkr0tWhzmBf; Wed, 20 Aug 2025 13:15:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 20 Aug 2025 09:14:59 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 75acf71786f2 - main - libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp Content-Language: en-US To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , Konstantin Belousov Cc: Aymeric Wibo , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202508192309.57JN9cNK038457@gitrepo.freebsd.org> <868qjejqdb.fsf@ltc.des.dev> <86wm6yia1i.fsf@ltc.des.dev> From: John Baldwin In-Reply-To: <86wm6yia1i.fsf@ltc.des.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/20/25 06:04, Dag-Erling Smørgrav wrote: > Konstantin Belousov writes: >> Dag-Erling Smørgrav writes: >>> Konstantin Belousov writes: >>>> Aymeric Wibo writes: >>>>> libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp >>>> This breaks the ABI, of course. >>> No, it does not. Please take the time to check before throwing >>> accusations around. >> If a symbol is removed from the library export list, its ABI is broken. > > Again, please *take the time to check* before lashing out. I promise > you we'll still be here when you get back. Well, in kib's defense, it is rather stupid to have a symbol map that is never used and thus _never verified_ checked into the tree for an internal lib. The bug was adding this symbol map in the first place, and it should probably be deleted. If at some point we decide to convert this library to actually be a shared library, that is the point at which we would have an ABI we are committed to and is when we should add a symbol map. This was arguably broken on the initial import back in 2016 as libifc as that Makefile set SHLIBDIR and SHLIB_MAJOR, but also set NO_PIC to disable the shared library build. I think adding the version map just built on this mistake, and we should remove all the shlib cruft and symbol versions until this library has a stable ABI. -- John Baldwin