Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Jun 2012 08:04:51 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r236738 - head/sys/kern
Message-ID:  <201206080804.q5884pnT041794@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Fri Jun  8 08:04:51 2012
New Revision: 236738
URL: http://svn.freebsd.org/changeset/base/236738

Log:
  Plug socket refcount leak on error in sys_sctp_peeloff.
  
  Reviewed by:	tuexen
  Approved by:	trasz (mentor)
  MFC after:	3 days

Modified:
  head/sys/kern/uipc_syscalls.c

Modified: head/sys/kern/uipc_syscalls.c
==============================================================================
--- head/sys/kern/uipc_syscalls.c	Fri Jun  8 07:44:42 2012	(r236737)
+++ head/sys/kern/uipc_syscalls.c	Fri Jun  8 08:04:51 2012	(r236738)
@@ -2327,11 +2327,11 @@ sys_sctp_peeloff(td, uap)
 		goto done2;
 	if (head->so_proto->pr_protocol != IPPROTO_SCTP) {
 		error = EOPNOTSUPP;
-		goto done2;
+		goto done;
 	}
 	error = sctp_can_peel_off(head, (sctp_assoc_t)uap->name);
 	if (error)
-		goto done2;
+		goto done;
 	/*
 	 * At this point we know we do have a assoc to pull
 	 * we proceed to get the fd setup. This may block



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206080804.q5884pnT041794>