From nobody Mon Oct 31 03:39:16 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N0zRF0rG2z4gT9v; Mon, 31 Oct 2022 03:39:21 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N0zRD0hpFz3b8m; Mon, 31 Oct 2022 03:39:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id pCq0ovALmSp39pLdvopCPc; Mon, 31 Oct 2022 03:39:19 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id pLdtoWdltlz8ppLduoitTe; Mon, 31 Oct 2022 03:39:19 +0000 X-Authority-Analysis: v=2.4 cv=VvEwvs6n c=1 sm=1 tr=0 ts=635f4367 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=Qawa6l4ZSaYA:10 a=pIhXSETnAAAA:8 a=6I5d2MoRAAAA:8 a=NEAV23lmAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=efAeHplXsmtgq-7jvmcA:9 a=CjuIK1q_8ugA:10 a=aStlkcwk48vnf0XRxVrg:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 14523687; Sun, 30 Oct 2022 20:39:17 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id EADD820D; Sun, 30 Oct 2022 20:39:16 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Kyle Evans cc: Florian Smeets , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 028382670670 - main - usr.bin: hook wg(8) up to the build In-reply-to: References: <202210290310.29T3AWtG040580@gitrepo.freebsd.org> <1642aa7b-1974-7cb9-a5cf-b6477abb034e@smeets.xyz> Comments: In-reply-to Kyle Evans message dated "Sun, 30 Oct 2022 21:47:03 -0500." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 30 Oct 2022 20:39:16 -0700 Message-Id: <20221031033916.EADD820D@slippy.cwsent.com> X-CMAE-Envelope: MS4xfKj/ADRcKyCiNcu0u+c9HUKfJdRM7cfEnhI6ocDlzHRipt05FalWnG72zWFWvFYxqJ1f/F4jPFuFlxdI76a05Vvr0preUWxSaSMR04XP/4uFdb3fTcDd fcCKQCwqUa1Rwkw9I524ZLfEQKFslU650cHwF0lEwHdAJYESpOr5qXcVwS3c6OAdd+peukdixseACX+fXYKiC3MR87gj4n+3D8+fURr32U/C3nLiw96m6mVV H+Z3ieaIC3e0B+5LggrT2UAjDIZhSGa20ijuzUfhogBSMyG2C8fZs1in+Iq+pF90Xzwkd0y1OyafPWBFceCzn4rS6e5RdWOnslA2sv19/DWTxHrSxxZEBdmk YyEksPt9 X-Rspamd-Queue-Id: 4N0zRD0hpFz3b8m X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.60 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[3.97.99.33:from]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N In message , Kyle Evans writes: > On Sun, Oct 30, 2022 at 8:22 AM Florian Smeets wrote: > > > > On 29.10.22 05:10, Kyle Evans wrote: > > > The branch main has been updated by kevans: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0283826706706c598fff86e16c42 > 604841c1a05a > > > > > > commit 0283826706706c598fff86e16c42604841c1a05a > > > Author: Kyle Evans > > > AuthorDate: 2022-10-29 03:04:56 +0000 > > > Commit: Kyle Evans > > > CommitDate: 2022-10-29 03:05:39 +0000 > > > > > > usr.bin: hook wg(8) up to the build > > > > > > wg(8) is used to manage WireGuard interfaces; see wg(4) and wg(8) bo > th > > > for more details and usage examples. > > I just migrated from the ports version to the in tree version, the only > > thing missing seems to be the rc script, other than that it's working fine. > > > > Should we import an rc script into base e.g. one the net/wireguard-tools > > provides? > > > > I wouldn't mind one, though we can't really provide the one the > wireguard-tools provides; it's based entirely off of wg-quick(8), > which we can't reasonably install in base (bash script and actually > uses bash-isms). I think our options are limited. Either import ksh from https://github.com/ksh93/ksh, resurrected ksh development, if the EPL 2.0 license is to our liking or try to simulate arrays, like we do in rc. I think the latter risks introducing bugs, not to mention cumbersome, while the former is very actively developed. Personally, I think we might want to revisit importation of the actively developed ksh (above), if not for public consumption (i.e. /bin/ksh), for support of arrays (as /usr/libexec/ksh). Many of the additional ksh features are POSIX as well. I think the last time we looked at anything ksh-like, it was for its interactive use. I think we should consider it for its scripting capabilities (as in /usr/libexec/ksh) only and let users choose interactive options from ports. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0