From owner-svn-src-head@freebsd.org Tue May 21 23:03:39 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD54B1593052; Tue, 21 May 2019 23:03:39 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B1DF85F2A; Tue, 21 May 2019 23:03:38 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x4LN3bX7081423; Tue, 21 May 2019 16:03:37 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x4LN3bMd081422; Tue, 21 May 2019 16:03:37 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905212303.x4LN3bMd081422@gndrsh.dnsmgr.net> Subject: Re: svn commit: r348073 - head/lib/libmd In-Reply-To: <201905212217.x4LMH1GG068159@repo.freebsd.org> To: Allan Jude Date: Tue, 21 May 2019 16:03:37 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 1B1DF85F2A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2019 23:03:39 -0000 > Author: allanjude > Date: Tue May 21 22:17:00 2019 > New Revision: 348073 > URL: https://svnweb.freebsd.org/changeset/base/348073 > > Log: > Add admonitions against using MD5 and SHA1 to the API man pages > > Modified: > head/lib/libmd/mdX.3 > head/lib/libmd/sha.3 > > Modified: head/lib/libmd/mdX.3 > ============================================================================== > --- head/lib/libmd/mdX.3 Tue May 21 22:11:53 2019 (r348072) > +++ head/lib/libmd/mdX.3 Tue May 21 22:17:00 2019 (r348073) > @@ -208,6 +208,8 @@ This code is derived directly from these implementatio > .Pp > Phk ristede runen. > .Sh BUGS > -No method is known to exist which finds two files having the same hash value, > -nor to find a file with a specific hash value. > -There is on the other hand no guarantee that such a method does not exist. > +The > +.Tn MD5 There needs to be a discussion about .Tn, some people are ripping them out of man pages, others are adding them. mandoc is a semantic mark up language, .Tn gives the following word the semantic of being a Tradename. Yes, I know, mandoc ignroes them BUTT other tools do not, mandoc is not the end all in what can process our man pages, groff/troff should still be able to produce photo typesetter output and the .Tn's look nice when you do that. I would like to see that we stop removing them and infact, as this man page does, properly recognize trademarks/names in our man pages "as is often required by law." Now, one final nit, I can neither verify nor deny that "MD5" is a tradename. > +algorithm has been proven to be vulnerable to practical collision > +attacks and should not be relied upon to produce unique outputs, > +.Em nor should they be used as part of a cryptographic signature scheme. > > Modified: head/lib/libmd/sha.3 > ============================================================================== > --- head/lib/libmd/sha.3 Tue May 21 22:11:53 2019 (r348072) > +++ head/lib/libmd/sha.3 Tue May 21 22:17:00 2019 (r348073) > @@ -191,9 +191,11 @@ published > .Tn FIPS > standards. > .Sh BUGS > -No method is known to exist which finds two files having the same hash value, > -nor to find a file with a specific hash value. > -There is on the other hand no guarantee that such a method does not exist. > +The > +.Tn SHA1 > +algorithm has been proven to be vulnerable to practical collision > +attacks and should not be relied upon to produce unique outputs, > +.Em nor should they be used as part of a cryptographic signature scheme. > .Pp > The > .Tn IA32 > > -- Rod Grimes rgrimes@freebsd.org