From nobody Fri Mar 13 08:32:31 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fXHmJ2kgJz6Vhw1 for ; Fri, 13 Mar 2026 08:32:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fXHmH6rssz3xR2 for ; Fri, 13 Mar 2026 08:32:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773390752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r6CEs5hQpCrFzNh3TdgmB4mRDhxYLUZcYn/LurkSt4Y=; b=dlZLjJFYGXg/dqIqy6XgnuuNu2k+aBZjZ+oVAEqs5BT7KRg6dGcoXzARmlcmDasneNfFkb vv1aVypOUCuGqUKNWSMT4Y/7hfXyk6RbEGZ6YzWqFVoh86btw7chFkVXBTyx6x7mLAw6gb gsok+RQhSQQcxydlRXfkD/BUkEIrysEdLtTZCckfPY6HNcwSgcrxAGOPX4XJ2pY+6Z//Qs lcYg/eotbFDDg4ytnx5cBYXip13yWiAC20vrr2lf9Znyga6PvMKBP1oOlX5cuI0AajBm8S mdB38ozQqcYLqpm4hzRtzwB/LDE5OFWsxmLx1IRNbAaOyp7EHan72WyS3eLkSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773390752; a=rsa-sha256; cv=none; b=oYzK+WV9g0VFcEy129lvbfdNwPqL/XJYqq0Eh63aa3aPU7QopwhosKE0wtEhmVxY+0m2AT RCoOd4XFTI4hn0sbE3u1drX4VH+qlwvJMzNOYA4uKr1FzWFwn39MC1rW378A37lTuvcajT WaBHql3yM++Onj1JvrKQrDCEQpTXaowenAHDcJ1erqKXka+IhRU1GcA+uH1xDuu4UxGE6b Efs8nloeYoViAbWPaaIAhAWIYF6b8MwibJGGbdUil+Z8VfdOk0wSWkASdzuRo4kto0YP8H In5Hk4WfWWr4IFxXaal6lAQ4vp2eJKHZR3WxdGdNonqzCTwTBtH4m86T++isIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773390752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r6CEs5hQpCrFzNh3TdgmB4mRDhxYLUZcYn/LurkSt4Y=; b=IFmowc2TxZid7DQ9meGJz3WAEvPs1xORVeg4QTwHAf14ZJ4EihGDWmMWYvGICrsk8i7mHC nS3Z6ClvuWlbS+YUlBUOhstZKZwekqPlOh5eJGW8/wnLLByz0A01bu1RG1fDpWpiXpmEWg Kf97yMJgRAMaeNLvvfRAaWZjIkU9z5QblZ0e829in2X1dDbm01clRknAiu6TEqDD+WDDQr qhkqqUmOnjpLSCojcSzUtJlUql3MCP3ypXcRX0xSdTzU7r8O72J8O/YBumYQ3WZ1FKmiau QV0iJrYUQXv8c+ov0jzmOHJToo8OM71fNHAJmDgukTZ03ZJ/eDHQGzR3EMQgMA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fXHmH5kWZz8hK for ; Fri, 13 Mar 2026 08:32:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ab38 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Mar 2026 08:32:31 +0000 To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 1d3ebc894819 - main - comms/bladerf: fix build with clang 21 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1d3ebc89481999cd5696097cf653b8e97f5eb8cb Auto-Submitted: auto-generated Date: Fri, 13 Mar 2026 08:32:31 +0000 Message-Id: <69b3cb9f.3ab38.fa59ad9@gitrepo.freebsd.org> The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=1d3ebc89481999cd5696097cf653b8e97f5eb8cb commit 1d3ebc89481999cd5696097cf653b8e97f5eb8cb Author: Dimitry Andric AuthorDate: 2026-02-23 21:02:54 +0000 Commit: Dimitry Andric CommitDate: 2026-03-13 08:32:26 +0000 comms/bladerf: fix build with clang 21 With clang 21 comms/bladerf fails to build, with errors similar to: /wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 71 | if (val[i] >= 'a' || val[i] <= 'f') { | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ This is a logic error: the logical operator should be `&&` here. It has been proposed as an upstream pull request: https://github.com/Nuand/bladeRF/pull/1045, but it is not yet merged. PR: 293393 Approved by: maintainer timeout (2 weeks) MFH: 2026Q1 --- .../patch-host_utilities_bladeRF-cli_src_cmd_flash__image.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/comms/bladerf/files/patch-host_utilities_bladeRF-cli_src_cmd_flash__image.c b/comms/bladerf/files/patch-host_utilities_bladeRF-cli_src_cmd_flash__image.c new file mode 100644 index 000000000000..3494c23d2ff5 --- /dev/null +++ b/comms/bladerf/files/patch-host_utilities_bladeRF-cli_src_cmd_flash__image.c @@ -0,0 +1,11 @@ +--- host/utilities/bladeRF-cli/src/cmd/flash_image.c.orig 2025-10-06 23:06:05 UTC ++++ host/utilities/bladeRF-cli/src/cmd/flash_image.c +@@ -68,7 +68,7 @@ static int handle_param(const char *param, char *val, + status = CLI_RET_INVPARAM; + } else { + for (i = 0; i < len && status == 0; i++) { +- if (val[i] >= 'a' || val[i] <= 'f') { ++ if (val[i] >= 'a' && val[i] <= 'f') { + val[i] -= 'a' - 'A'; + } else if (!((val[i] >= '0' && val[i] <= '9') || + (val[i] >= 'A' && val[i] <= 'F'))) {