From owner-cvs-src@FreeBSD.ORG  Fri Jun  4 14:48:48 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 43C0816A4CE; Fri,  4 Jun 2004 14:48:48 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DDC2A43D1F; Fri,  4 Jun 2004 14:48:47 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i54LlxWZ013970;
	Fri, 4 Jun 2004 17:47:59 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i54Llxfx013967;
	Fri, 4 Jun 2004 17:47:59 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Fri, 4 Jun 2004 17:47:59 -0400 (EDT)
From: Robert Watson <rwatson@freebsd.org>
X-Sender: robert@fledge.watson.org
To: Maxime Henrion <mux@freebsd.org>
In-Reply-To: <20040604210841.GL9228@elvis.mu.org>
Message-ID: <Pine.NEB.3.96L.1040604174643.11973B-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2004 21:48:48 -0000


On Fri, 4 Jun 2004, Maxime Henrion wrote:

> > >   dev.fxp0.int_delay: 1000
> > >   dev.fxp0.bundle_max: 6
> > >   dev.fxp0.rnr: 0
> > >   dev.fxp0.noflow: 0
> > 
> > What are your thoughts about making noflow the default?  Having an fxp
> > machine panic and DoS an entire network is not friendly.
> 
> I'm not opposed to that.  I'd like to hear rwatson confirming this since
> he's the one who implemented that sysctl, but I think it is fairly safe. 

I'm fine with it, but I've never had the opportunity to benchmark to what
extent disabling flow control has on if_fxp.  It would be probably be
useful to do that first. 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research