From owner-freebsd-gnome@FreeBSD.ORG  Tue May 22 15:02:01 2007
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
X-Original-To: gnome@freebsd.org
Delivered-To: freebsd-gnome@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E84AF16A469
	for <gnome@freebsd.org>; Tue, 22 May 2007 15:02:01 +0000 (UTC)
	(envelope-from stephen@math.missouri.edu)
Received: from math.missouri.edu (math.missouri.edu [128.206.184.200])
	by mx1.freebsd.org (Postfix) with ESMTP id B51F613C455
	for <gnome@freebsd.org>; Tue, 22 May 2007 15:02:01 +0000 (UTC)
	(envelope-from stephen@math.missouri.edu)
Received: from [128.206.184.213] (cauchy.math.missouri.edu [128.206.184.213])
	by math.missouri.edu (8.13.1/8.13.1) with ESMTP id l4MEZWWK011545;
	Tue, 22 May 2007 09:35:32 -0500 (CDT)
	(envelope-from stephen@math.missouri.edu)
Message-ID: <4652FFB4.8060107@math.missouri.edu>
Date: Tue, 22 May 2007 09:35:32 -0500
From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.2) Gecko/20070505 SeaMonkey/1.1.1
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <465291FB.4010901@math.missouri.edu>
	<20070522071941.GB59910@xor.obsecurity.org>
In-Reply-To: <20070522071941.GB59910@xor.obsecurity.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.88/3281/Tue May 22 03:50:43 2007 on math.missouri.edu
X-Virus-Status: Clean
Cc: gnome@freebsd.org, freebsd-ports@freebsd.org
Subject: Re: More speed increases for make-ing ports
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2007 15:02:02 -0000

Kris Kennaway wrote:
> On Tue, May 22, 2007 at 01:47:23AM -0500, Stephen Montgomery-Smith wrote:
>   
>> This small modification cuts off about 25% off pkg_version on my system.
>>
>> Basically bsd.gnome.mk recursively finds all the dependencies, but many 
>> of them are listed many times.  This makes make work extra hard when it 
>> doesn't have to.  I simply weed out the repeated entries.
>>
>>     
>
>   
>> --- bsd.gnome.mk-orig	Tue May 22 01:29:08 2007
>> +++ bsd.gnome.mk	Tue May 22 01:29:22 2007
>> @@ -655,6 +655,8 @@
>>  _USE_GNOME+=	${${component}_USE_GNOME_IMPL} ${component}
>>  . endfor
>>  
>> +_USE_GNOME!=(for i in ${_USE_GNOME}; do ${ECHO_CMD} $$i; done) | sort -u
>> +
>>  # Setup the GTK+ API version for pixbuf loaders, input method modules,
>>  # and theme engines.
>>  PLIST_SUB+=			GTK2_VERSION="${GTK2_VERSION}"
>>     
>
> Be careful, != assignments may add thousands of process invocations to
> large targets like 'make index' and can slow it down dramatically.
>
> Kris
>
>
>   

Thanks for the warnings.  It turns out that this can be done without 
"!=", but even if this were not the case, I think that in this situation 
the savings would definitely outweigh the costs.  For example, this 
dramatically improves the time for invocations of "make -V PKGNAME" for 
deskutils/alacarte (on my system from about 1.5 seconds to .3 seconds).  
It only affects a few ports, but enough, I think, to increase the speed 
of "make index" noticeably albeit not dramatically.

Stephen