From nobody Wed Mar 25 15:58:31 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgs5M2Y0Cz6WRx2 for ; Wed, 25 Mar 2026 15:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgs5M1lJVz3KdG for ; Wed, 25 Mar 2026 15:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774454311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pzsC6Kh8xqLuA8WPAunkYEpGEjsPzwrTrcHHlBJyvFo=; b=UsPqcQ7lgiSvpg2ovJHpwn0dBcO3f7KyFXTl7Ntf0ypWVALm+V5FGkrRhbeMaf3OQW3ZxW dlZ4cE6dE2JO4B80/XDP9mqbqYvwlrCyBsxmNEY6T7cEbtLw8+sRhEbnDgKt9iUSLO4E8V J4zdzHfyzLnhJJIlKHp0Q53PyvwUGZ9ckC/z4e8kJUIOj9bK9HfMUoAZwpXPmlvdcf03iM m5szfoYQQFqzcH6qStDNGyOLTnAFqK+L+Lp/49zQ4TqhYXHz5eyHZukGDZQZtXIEQI0gjc V6wFB4MHTpNEYwf1dI5uNapJ/ZucGhUoUgNj/nWpgxUDNVH+7q9ACz1bhJ1WlA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774454311; a=rsa-sha256; cv=none; b=P63qokh889xTFX/wnRvcaPlehCCjE/tV8WBj4KPqkXL0sVkKk59uRq1+OuEZhBV6FANGRt flQmrxn71a7/5hp6MjEDjpOzFJOu87ZRrWkmxV9KgwfUw5VuhW3uc59lL/MSc929DGkh8u xXWMI6JgPXM4jl4q3DqUPt6181myoZD5ze0ekbevXf13+KDDGrf82CPRGkR9cFw8yVL5kY jMrBNCiWRv3mtIF3RKoPjRJLQT2MFT5lyxA2ztfd2YcEaXBFpvk6LZl782gWHFxpuN3f5r 6mpNfa8WgQvemVU263c1IizSGzGno9COgDCzDNnRfoErp3TODLQAymRYbonGSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774454311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pzsC6Kh8xqLuA8WPAunkYEpGEjsPzwrTrcHHlBJyvFo=; b=Em0T0z2HWI4oARoS4fje3GY9xEvBMQW0y93WIbLsp382ZLuVB6qdOIbujMwlqzL+U9Imgl cjhZuJAndDbPpRtQPoqKU6eJdhEfWn7Zc1P2MNRxCElHw56Lq5Iqy+p3GA0/ihFNSJVpAH kPXvOera7Z4457znwd2E/KM1GCLURZjdeL9Ahwqf/84ryuyHfAq+E47vbNFzp2stmfWz8/ 8RYZRVJBaqRNca4purfcy2koNyHZ3dGuPFdCJkaB9xiQrtXa+RFktya7Wh9MbofdRGS8KS EExPbHNJxNhfEMqNqTbFnQsX8w+uEpJPVHSE4V5iSS/zbZ/4OlFByTrvnIcPFA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fgs5M17Qmz1BhL for ; Wed, 25 Mar 2026 15:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 268b1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Mar 2026 15:58:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Cochard Subject: git: 648d0fefd757 - main - ipfw: skip tests if required sysctl is not set List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 648d0fefd7573080b01d44cad8c39ad658f8e44f Auto-Submitted: auto-generated Date: Wed, 25 Mar 2026 15:58:31 +0000 Message-Id: <69c40627.268b1.1b51d5ca@gitrepo.freebsd.org> The branch main has been updated by olivier: URL: https://cgit.FreeBSD.org/src/commit/?id=648d0fefd7573080b01d44cad8c39ad658f8e44f commit 648d0fefd7573080b01d44cad8c39ad658f8e44f Author: Olivier Cochard AuthorDate: 2026-03-25 15:47:44 +0000 Commit: Olivier Cochard CommitDate: 2026-03-25 15:55:57 +0000 ipfw: skip tests if required sysctl is not set Since this is a configuration prerequisite rather than a test failure, use atf_skip instead. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D56069 --- tests/sys/netpfil/common/utils.subr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sys/netpfil/common/utils.subr b/tests/sys/netpfil/common/utils.subr index 8f298960bef5..8885495cec11 100644 --- a/tests/sys/netpfil/common/utils.subr +++ b/tests/sys/netpfil/common/utils.subr @@ -88,7 +88,7 @@ firewall_init() if ! kldstat -q -m ipfw; then atf_skip "This test requires ipfw" elif [ $(sysctl -n net.inet.ip.fw.default_to_accept) -ne 1 ]; then - atf_fail "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable" + atf_skip "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable" fi elif [ ${firewall} == "pf" ]; then if [ ! -c /dev/pf ]; then