From owner-cvs-src@FreeBSD.ORG Wed Jul 23 16:44:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC11137B404; Wed, 23 Jul 2003 16:44:07 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC2F243FA3; Wed, 23 Jul 2003 16:44:06 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9/8.12.3) with ESMTP id h6NNhlFL061901; Wed, 23 Jul 2003 17:43:47 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 23 Jul 2003 17:43:42 -0600 (MDT) Message-Id: <20030723.174342.72711741.imp@bsdimp.com> To: jhb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: References: <20030722.164223.00776481.imp@bsdimp.com> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: phk@phk.freebsd.dk cc: src-committers@FreeBSD.org cc: bde@zeta.org.au cc: paul@freebsd-services.com cc: cvs-src@FreeBSD.org cc: das@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lnc if_lnc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 23:44:08 -0000 In message: John Baldwin writes: : Umm, you should be having to unload if_wi then when unloading pccard. No you should not. it is a big pain in the ass, and completely unnecessary. : If if_wi tries to call a pccard method on an attached pccard device : after pccard is unloaded, I'm sure lots of things are going to break. it can't do that. When pccard detaches, it detaches its children. with nothing there to reattach the devices to pccard. : Hmmm. I guess if unloading pccard detaches all pccard devices and their : children then it is safe if you always use KOBJ methods and never link : against any functions for your bus attachments. That's why pccard tries very hard to refuse to export ANY symbols that pccard client drivers use. Other busses should do likewise. warner