From owner-freebsd-ports@FreeBSD.ORG Sat Jun 19 19:12:34 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EB6A16A4CE for ; Sat, 19 Jun 2004 19:12:34 +0000 (GMT) Received: from mail.ciam.ru (mail.ciam.ru [213.147.57.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49C1343D54 for ; Sat, 19 Jun 2004 19:12:33 +0000 (GMT) (envelope-from sem@ciam.ru) Received: from ppp9-171.pppoe.mtu-net.ru ([81.195.9.171] helo=ciam.ru) by mail.ciam.ru with asmtp (Exim 4.x) id 1BblG4-0004Iq-GU; Sat, 19 Jun 2004 23:12:08 +0400 Message-ID: <40D49011.2010207@ciam.ru> Date: Sat, 19 Jun 2004 23:12:17 +0400 From: Sergey Matveychuk User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Thomas-Martin Seck References: <20040619114707.GC568@laurel.tmseck.homedns.org> <3D4C2946-C1E9-11D8-9250-00039312D914@fillmore-labs.com> <20040619124636.GD568@laurel.tmseck.homedns.org> In-Reply-To: <20040619124636.GD568@laurel.tmseck.homedns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-ports@freebsd.org cc: Oliver Eikemeier Subject: Re: CONFLICTS usage question X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2004 19:12:34 -0000 Thomas-Martin Seck wrote: > * Oliver Eikemeier (eikemeier@fillmore-labs.com): [...] >>It is feasible. You could check PKGORIGINS or do the >>check-already-installed test >>before check-conflicts, filtering out previous results. The question >>remains: >>Why? > > > Well, why not? If the already-installed check is done beforehand, the > self-conflict message does not show up and the user is not confused. > > If (s)he forces the reinstall, the self-conflict is silently discarded > and the user is still not confused (at least not by the ports system). > > I definitely think this is worth pursuing. Believe me, we can't move check-already-installed _before_ check-conflicts target. The reason is: 1) check-already-installed use PLIST. 2) The final PLIST generated in generate-plist target. 3) Maintainers can modify PLIST. So we need genereate-plist after pre_install* targets. So, if we'll move it, we'll brake check-already-installed target. And we even don't nitice it! Because of all will seem to be OK: no warning from bento. Do you see, how many side effects may be hiden behind so easy operation? Do you understand the Oliver's reaction now? Well, we can move already-installed target _after_ check-already-installed. It looks much safer. But we need to think twice before too. I discover a big secret for you :), I know some quite ugly parts in bsd.port.mk that I can't change without hundreds or thousands ports breakage. -- Sem.