From owner-freebsd-current@freebsd.org Sun Aug 12 19:46:51 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B4FF107A8AE for ; Sun, 12 Aug 2018 19:46:51 +0000 (UTC) (envelope-from trond@fagskolen.gjovik.no) Received: from smtp.fagskolen.gjovik.no (smtp.fagskolen.gjovik.no [IPv6:2001:700:1100:1:200:ff:fe00:b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.fagskolen.gjovik.no", Issuer "Fagskolen i Gj??vik" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 68F7476BEA; Sun, 12 Aug 2018 19:46:50 +0000 (UTC) (envelope-from trond@fagskolen.gjovik.no) Received: from mail.fig.ol.no (localhost [127.0.0.1]) by mail.fig.ol.no (8.15.2/8.15.2) with ESMTPS id w7CJkkwG033268 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 12 Aug 2018 21:46:47 +0200 (CEST) (envelope-from trond@fagskolen.gjovik.no) Received: from localhost (trond@localhost) by mail.fig.ol.no (8.15.2/8.15.2/Submit) with ESMTP id w7CJkj6v033265; Sun, 12 Aug 2018 21:46:46 +0200 (CEST) (envelope-from trond@fagskolen.gjovik.no) X-Authentication-Warning: mail.fig.ol.no: trond owned process doing -bs Date: Sun, 12 Aug 2018 21:46:45 +0200 (CEST) From: =?ISO-8859-1?Q?Trond_Endrest=F8l?= Sender: Trond.Endrestol@fagskolen.gjovik.no To: Michael Butler cc: FreeBSD Current , mmacy@freebsd.org Subject: Re: kernel build failure In-Reply-To: Message-ID: References: <748179e1-72bd-99e3-2267-302274be3d32@protected-networks.net> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) Organization: Fagskolen Innlandet OpenPGP: url=http://fig.ol.no/~trond/trond.key MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.fig.ol.no Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2018 19:46:51 -0000 On Sun, 12 Aug 2018 16:51+0200, Trond Endrestøl wrote: > On Sun, 12 Aug 2018 09:37-0400, Michael Butler wrote: > > > Is anyone else seeing this when building a new kernel with ZFS compiled in? > > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vers.o > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/kernel > > --- kernel --- > > linking kernel > > ld: error: undefined symbol: dbuf_stats_init > > >>> referenced by dbuf.c > > >>> dbuf.o:(dbuf_init) > > > > ld: error: undefined symbol: dbuf_stats_destroy > > >>> referenced by dbuf.c > > >>> dbuf.o:(dbuf_fini) > > *** [kernel] Error code 1 > > I was just about to create a thread of my own. > > I suspect r337670 didn't add everything > cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c depends on. See > lines 652 and 697. > > Meanwhile, I'll attempt to revert to r337669. r337669 builds and runs. Looking further into r337670, it seems cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dbuf.h added prototypes for dbuf_stats_init() and dbuf_stats_destroy(), but no implementation can be found in any of the files affected by r337670. -- Trond. From owner-freebsd-current@freebsd.org Sun Aug 12 21:39:17 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 486A0107D348 for ; Sun, 12 Aug 2018 21:39:17 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE5A67ABD2 for ; Sun, 12 Aug 2018 21:39:16 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id B3EA01C4E4 for ; Sun, 12 Aug 2018 21:39:16 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f47.google.com with SMTP id 139-v6so10491774itf.0 for ; Sun, 12 Aug 2018 14:39:16 -0700 (PDT) X-Gm-Message-State: AOUpUlE7mij64KayEH/0NjGMrzm8kxr89aOq5tLuUZF9lJuu/HIa6kBa JMnX4zEU2wuhXakO7QT/t18w004vuWvqgfmMAQE= X-Google-Smtp-Source: AA+uWPwn2zqb7Aq4I4ZDJcvzVMWeC0WBuvsZoj46PU+jzFAHoOrpeKVpgWKInIkl4YLGnuG1rpApqnjKZW8iOpY2DkM= X-Received: by 2002:a24:6c04:: with SMTP id w4-v6mr8865536itb.4.1534109956119; Sun, 12 Aug 2018 14:39:16 -0700 (PDT) MIME-Version: 1.0 References: <748179e1-72bd-99e3-2267-302274be3d32@protected-networks.net> In-Reply-To: From: Matthew Macy Date: Sun, 12 Aug 2018 14:39:04 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: kernel build failure To: Trond.Endrestol@fagskolen.gjovik.no Cc: Michael Butler , freebsd-current Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2018 21:39:17 -0000 Sorry guys, last time I touched ZFS I tried to push to make it an option to statically link and was actually told that it wasn't something anyone else wanted. The issue comes from ZFS not being in NOTES and thus not in LINT. -M On Sun, Aug 12, 2018 at 12:46 PM Trond Endrest=C3=B8l < Trond.Endrestol@fagskolen.gjovik.no> wrote: > On Sun, 12 Aug 2018 16:51+0200, Trond Endrest=C3=B8l wrote: > > > On Sun, 12 Aug 2018 09:37-0400, Michael Butler wrote: > > > > > Is anyone else seeing this when building a new kernel with ZFS > compiled in? > > > > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vers.o > > > Building /usr/obj/usr/src/amd64.amd64/sys/VM01/kernel > > > --- kernel --- > > > linking kernel > > > ld: error: undefined symbol: dbuf_stats_init > > > >>> referenced by dbuf.c > > > >>> dbuf.o:(dbuf_init) > > > > > > ld: error: undefined symbol: dbuf_stats_destroy > > > >>> referenced by dbuf.c > > > >>> dbuf.o:(dbuf_fini) > > > *** [kernel] Error code 1 > > > > I was just about to create a thread of my own. > > > > I suspect r337670 didn't add everything > > cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c depends on. See > > lines 652 and 697. > > > > Meanwhile, I'll attempt to revert to r337669. > > r337669 builds and runs. > > Looking further into r337670, it seems > cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dbuf.h added prototypes > for dbuf_stats_init() and dbuf_stats_destroy(), but no implementation > can be found in any of the files affected by r337670. > > -- > Trond.