From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 06:39:03 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2191916A4CE; Tue, 22 Jun 2004 06:39:03 +0000 (GMT)
Received: from imap.univie.ac.at (mail.univie.ac.at [131.130.1.27])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5D77343D53; Tue, 22 Jun 2004 06:39:02 +0000 (GMT)
	(envelope-from le@FreeBSD.org)
Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11])
	by imap.univie.ac.at (8.12.10/8.12.10) with ESMTP id i5M6cnoG879380;
	Tue, 22 Jun 2004 08:38:51 +0200
Date: Tue, 22 Jun 2004 08:38:49 +0200 (CEST)
From: Lukas Ertl <le@FreeBSD.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
In-Reply-To: <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca>
Message-ID: <20040622083814.C639@korben.in.tern>
References: <20040622035316.30729.qmail@web53702.mail.yahoo.com>
 <6.1.0.6.1.20040622051016.03cae4e8@popserver.sfu.ca>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-DCC-ZID-Univie-Metrics: mail 4247; Body=5 Fuz1=5 Fuz2=5
cc: grog@FreeBSD.org
cc: current@FreeBSD.org
cc: chancedj@yahoo.com
cc: phk@FreeBSD.org
Subject: Re: vinum crashing with latest current
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 06:39:03 -0000

On Tue, 22 Jun 2004, Colin Percival wrote:

> At 04:53 22/06/2004, Daryl Chance wrote:
>
> Now, I'm not sure which of these is correct, but ONE of the following
> two patches should be applied:
> --- src/sys/dev/vinum/vinumio.c	17 Jun 2004 17:16:47 -0000	1.99
> +++ src/sys/dev/vinum/vinumio.c	22 Jun 2004 04:29:08 -0000
> @@ -68,7 +68,7 @@ open_drive(struct drive *drive, struct t
> 	drive->lasterror = ENOTBLK;
>     else {
>         DROP_GIANT();
> -	drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, NULL);
> +	drive->lasterror = (dsw->d_open) (drive->dev, FWRITE | FREAD, 0, td);
>         PICKUP_GIANT();
>     }

Thanks for catching this one!

cheers,
le

-- 
Lukas Ertl                         http://homepage.univie.ac.at/l.ertl/
le@FreeBSD.org                     http://people.freebsd.org/~le/