From owner-svn-ports-head@freebsd.org Tue Nov 14 15:12:10 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 977ECDC17A3; Tue, 14 Nov 2017 15:12:10 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7817D29A9; Tue, 14 Nov 2017 15:12:10 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id B75AD1D661; Tue, 14 Nov 2017 15:12:09 +0000 (UTC) From: Jan Beich To: Alexey Dokuchaev Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r454171 - head/multimedia/libvpx References: <201711141014.vAEAEjpT071974@repo.freebsd.org> <20171114102535.GA56721@FreeBSD.org> <20171114110244.GB56721@FreeBSD.org> Date: Tue, 14 Nov 2017 16:12:05 +0100 In-Reply-To: <20171114110244.GB56721@FreeBSD.org> (Alexey Dokuchaev's message of "Tue, 14 Nov 2017 11:02:44 +0000") Message-ID: <8tf8-hp2y-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 15:12:10 -0000 Alexey Dokuchaev writes: > On Tue, Nov 14, 2017 at 11:44:00AM +0100, Jan Beich wrote: > >> Alexey Dokuchaev writes: >> > Actually, could you add a real 2319-byte patch file under files/ instead? >> > Last time I wanted to build some older version of `devel/android-tools-adb' >> > which has the same "bug" and could not because the patch was no longer >> > fetchable. Thank you, >> >> Why it wasn't fetchable? The GitHub mirror should be identical and is >> already used to fetch the main distfile. Provide more details. > > cd /usr/ports/devel/android-tools-adb > svn up -r424893 . > make > ... > => Attempting to fetch https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch > fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size unknown > fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size of remote file is not known > b4cff495a1f9.patch 2084 B 6281 kBps 00m00s > => Fetched file size mismatch (expected 2066, actual 2084) "git format-patch" from Git 2.11 or later honors commit abbreviation. No wonder it affects .patch links from GitHub. cf. https://github.com/git/git/commit/e6c587c733b4 >> I use PATCHFILES to denote unmodified fixes from upstream. Putting them >> under files/ requires generating with --no-prefix and pacifying portlint >> via "make makepatch". That'd be no fun if more than one patch touches >> the same files. > > I don't think that this is more important than being unable to svn up > to some past revision and having to play tricks with -DNO_CHECKSUM and > hoping everything will be OK and it's just stupid GitHub changed their > output again. That's optimistic for ports that specify only 7-hexdigits in GH_TAGNAME or vanishing MASTER_SITES. Not to mention, partial downgrades have never been supported because Mk/* bits provide limited backward compatibility.