Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 25 Dec 2015 00:13:49 +0100
From:      Jilles Tjoelker <jilles@stack.nl>
To:        freebsd-arch@freebsd.org
Subject:   Expanding _PATH_DEFPATH
Message-ID:  <20151224231349.GA5821@stack.nl>

next in thread | raw e-mail | index | archive | help
In <paths.h> there is a #define _PATH_DEFPATH which is set to
/usr/bin:/bin. This does not include /sbin, /usr/sbin and ports
(/usr/local/bin and /usr/local/sbin) directories and is therefore often
insufficient.

This is rarely a problem because _PATH_DEFPATH is overridden by
/etc/login.conf, ~/.login_conf and/or shell startup files. _PATH_DEFPATH
is still used as a default by execlp(), execvp(), posix_spawnp() and sh
if PATH is not set, and by cron.

Especially the latter is a common trap (most recently in PR 204813). We
can fix it for 99% by changing _PATH_DEFPATH to
/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin
This is the path in the default class in the default /etc/login.conf,
excluding ~/bin which would not be expanded properly in a string
constant.

For consistency, the _PATH_DEFPATH for RESCUE below and in 3 man pages
(exec.3, posix_spawn.3, crontab.5) need to be adjusted as well.

-- 
Jilles Tjoelker



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151224231349.GA5821>