From owner-freebsd-current@FreeBSD.ORG Tue May 22 19:22:31 2007 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E301F16A4D1; Tue, 22 May 2007 19:22:31 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by mx1.freebsd.org (Postfix) with ESMTP id 8070013C45B; Tue, 22 May 2007 19:22:31 +0000 (UTC) (envelope-from marcus@FreeBSD.org) X-TACSUNS: Virus Scanned Received: from rooster.cisco.com (localhost [127.0.0.1]) by av-tac-rtp.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id l4MJML216579; Tue, 22 May 2007 15:22:21 -0400 (EDT) Received: from [64.102.193.121] (dhcp-64-102-193-121.cisco.com [64.102.193.121]) by rooster.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id l4MJMJq04791; Tue, 22 May 2007 15:22:19 -0400 (EDT) Message-ID: <46534301.10005@FreeBSD.org> Date: Tue, 22 May 2007 15:22:41 -0400 From: Joe Marcus Clarke Organization: FreeBSD, Inc. User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326) MIME-Version: 1.0 To: "current@freebsd.org" X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: pjd@FreeBSD.org Subject: [Fwd: Serious problem with mount(8)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 19:22:32 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think this email got eaten by the recent mailman problems, so I'm resending. Any feedback on this would be appreciated. Joe - -------- Original Message -------- Subject: Serious problem with mount(8) Date: Thu, 17 May 2007 14:19:21 -0400 From: Joe Marcus Clarke Organization: FreeBSD, Inc. To: current@freebsd.org CC: pjd@freebsd.org I really don't know why I didn't notice this before, but when mount was converted to use the pidfile(3) API three months ago, the behavior of mount(8) changed with regard to restarting mountd. A pidfile client cannot use pidfile_open(3) as this will truncate the pidfile. The result is that mount reads in a PID of 0, and when it tries to send a SIGHUP to this PID, it kills itself. Consequently, this is breaking the ports Tinderbox. I suppose we could revert to the previous behavior, but use flopen() to test if the file is actually locked. Maybe something like this: http://www.marcuscom.com/downloads/mount.c.diff Joe - -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGU0MBb2iPiv4Uz4cRAkHlAJ9inrjwmUU8+iaFbmQ/06z6Wak2ygCeN19q Hlqo5gpIBOdoWcjAUVMkz8c= =gUKr -----END PGP SIGNATURE-----